devbox: clean up profile history after sync #2449
Merged
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After syncing the flake packages to the profile, remove all old generations of the Nix profile. This allows the Nix garbage collector to eventually remove any old packages. Opted for a Go implementation instead of calling `nix profile wipe-history` because deleting the history is pretty simple and this is faster.
mohsenari
approved these changes
Dec 12, 2024
savil
approved these changes
Dec 12, 2024
@mohsenari I don't follow. What regression are you referring to? |
@savil I'm talking about potential changes to this function in the future, causing regression |
|
@mohsenari I added an assertion to a testscripts test to ensure that the history is pruned after adding/removing packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After syncing the flake packages to the profile, remove all old generations of the Nix profile. This allows the Nix garbage collector to eventually remove any old packages.
Opted for a Go implementation instead of calling
nix profile wipe-historybecause deleting the history is pretty simple and this is faster.