This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Remove unnecessary apiserver flags #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were somehow preventing the navigator API server from seeing the user that made the original request to the k8s API server.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
The navigator apiserver, on Kubernetes 1.7, fails with the error: ``` F1109 14:17:08.755824 56 main.go:40] cluster doesn't provide requestheader-client-ca-file ``` See: https://travis-ci.org/jetstack/navigator/jobs/299652901#L1183 We used to supply that as a command line argument, but those arguments caused other problems with RBAC. So we've decided to stop testing on 1.7.
|
@munnerz See #116 for an example of how Kubernetes 1.7 also has the same RBAC issues which were being masked by the prepare-e2e.sh RBAC configuration. Hopefully #109 is resolved in 1.8.{1,2,3} so I suggest we merge this. And upgrade our tests to use Kubernetes 1.8.3 as soon as it's supported by Minikube: kubernetes/minikube#2156 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were somehow preventing the navigator API server from seeing the user that
made the original request to the k8s API server.
Fixes: #110
Release note: