Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add all supported image versions to .travis.yml #28

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Conversation

lachlan-roberts
Copy link
Contributor

Not sure if we should keep the TravisCI if we have Jenkins going already. The travis CI runs in 10 minutes while our Jenkins tests runs in about 3min. Might be good to keep the travis one as a backup.

The pgp-happy-eyeballs/raw/master/hack-my-builds.sh is maintained by tianon who is a maintainer of the docker-library. And this was used in a similar way on TravisCI for their projects in docker-library before they switched to using Github CI.

the hack-my-builds.sh script which is intended for use in disposable CI environments such as those provided by Travis CI (see docker-library/php#666 and the linked PRs for implementation examples).

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
.travis.yml Show resolved Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Copy link

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than a niggle LGTM

generateTravis.sh Outdated Show resolved Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts merged commit cb9fa91 into master Aug 18, 2020
@lachlan-roberts lachlan-roberts deleted the TravisCI branch August 18, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants