Issue #4567 - Applying fixes from PR #4570 review

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
jetty · Feb 20, 2020 · 16230e6 · 16230e6
1 parent 5df8b05
commit 16230e6
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/jetty-util/src/main/java/org/eclipse/jetty/util/log/StdErrLog.java b/jetty-util/src/main/java/org/eclipse/jetty/util/log/StdErrLog.java
@@ -121,10 +121,12 @@ public static void setTagPad(int pad)
         __threadNamePadding = pad;
     }
 
+    @SuppressWarnings("UnusedAssignment")
     private int _level = LEVEL_INFO;
     // Level that this Logger was configured as (remembered in special case of .setDebugEnabled())
     private int _configuredLevel;
     private PrintStream _stderr = System.err;
+    @SuppressWarnings("UnusedAssignment")
     private boolean _source = SOURCE;
     // Print the long form names, otherwise use abbreviated
     private boolean _printLongNames = LONG_CLASSNAMES;
@@ -216,7 +218,7 @@ public StdErrLog(String name, Properties props)
         {
             // allow stacktrace display to be controlled by properties as well
             String stacks = getLoggingProperty(Log.PROPS, _name, "STACKS");
-            _hideStacks = stacks == null ? false : !Boolean.parseBoolean(stacks);
+            _hideStacks = stacks != null && !Boolean.parseBoolean(stacks);
         }
         catch (AccessControlException ignore)
         {
@@ -235,6 +237,7 @@ public void setPrintLongNames(boolean printLongNames)
         this._printLongNames = printLongNames;
     }
 
+    @SuppressWarnings("unused")
     public boolean isPrintLongNames()
     {
         return this._printLongNames;
@@ -461,6 +464,7 @@ private void format(StringBuilder builder, String level, String msg, Object... i
             msg = "";
             for (int i = 0; i < msgArgsLen; i++)
             {
+                //noinspection StringConcatenationInLoop
                 msg += "{} ";
             }
         }
@@ -492,7 +496,7 @@ private void format(StringBuilder builder, String level, String msg, Object... i
         {
             if (isHideStacks())
             {
-                builder.append(": " + cause);
+                builder.append(": ").append(cause);
             }
             else
             {
@@ -599,9 +603,8 @@ else if (p == 0)
         {
             Throwable source = new Throwable();
             StackTraceElement[] frames = source.getStackTrace();
-            for (int i = 0; i < frames.length; i++)
+            for (final StackTraceElement frame : frames)
             {
-                final StackTraceElement frame = frames[i];
                 String clazz = frame.getClassName();
                 if (clazz.equals(StdErrLog.class.getName()) || clazz.equals(Log.class.getName()))
                 {