Experiment with IteratingCallback

The previous semantic of `onCompleteFailure` has been renamed to `onFailure(Throwable)`, which is called immediately (but serialized) on either an abort or a failure.   A new `onCompleteFailure(Throwable)` method has been added that is called only after a `failed(throwable)` or a `abort(Throwable)` followed by `succeeded()` or `failed(Throwable)``

No usage has yet been made of the new `onCompleteFailure`, but the ICB implementation has been completely replaced by the one developed in #11876

documentation/jetty-documentation/src/main/java/org/eclipse/jetty/docs/programming/ContentDocs.java

@@ -361,7 +361,7 @@ protected void onCompleteSuccess()
         }
 
         @Override
-        protected void onCompleteFailure(Throwable failure)
+        protected void onFailure(Throwable failure)
         {
             // In case of a failure, either on the
             // read or on the write, release the chunk.

documentation/jetty-documentation/src/main/java/org/eclipse/jetty/docs/programming/SelectorManagerDocs.java

@@ -298,7 +298,7 @@ protected void onCompleteSuccess()
                 }
 
                 @Override
-                protected void onCompleteFailure(Throwable cause)
+                protected void onFailure(Throwable cause)
                 {
                     // The iteration completed with a failure.
                     getEndPoint().close(cause);

documentation/jetty-documentation/src/main/java/org/eclipse/jetty/docs/programming/WebSocketDocs.java

@@ -541,7 +541,7 @@ protected void onCompleteSuccess()
             }
 
             @Override
-            protected void onCompleteFailure(Throwable x)
+            protected void onFailure(Throwable x)
             {
                 x.printStackTrace();
             }

documentation/jetty-documentation/src/main/java/org/eclipse/jetty/docs/programming/server/ServerDocs.java

@@ -241,7 +241,7 @@ protected void onCompleteSuccess()
             }
 
             @Override
-            protected void onCompleteFailure(Throwable cause)
+            protected void onFailure(Throwable cause)
             {
                 getEndPoint().close(cause);
             }

jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/HttpSender.java

@@ -591,7 +591,7 @@ else if (expect100)
         }
 
         @Override
-        protected void onCompleteFailure(Throwable x)
+        protected void onFailure(Throwable x)
         {
             if (chunk != null)
             {

jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/internal/HttpSenderOverHTTP.java

@@ -248,9 +248,9 @@ protected void onCompleteSuccess()
         }
 
         @Override
-        protected void onCompleteFailure(Throwable cause)
+        protected void onFailure(Throwable cause)
         {
-            super.onCompleteFailure(cause);
+            super.onFailure(cause);
             release();
             callback.failed(cause);
         }
@@ -335,7 +335,7 @@ protected Action process() throws Exception
         }
 
         @Override
-        protected void onCompleteFailure(Throwable cause)
+        protected void onFailure(Throwable cause)
         {
             release();
             callback.failed(cause);

jetty-core/jetty-fcgi/jetty-fcgi-client/src/main/java/org/eclipse/jetty/fcgi/generator/Flusher.java

@@ -109,7 +109,7 @@ protected void onSuccess()
         }
 
         @Override
-        public void onCompleteFailure(Throwable x)
+        public void onFailure(Throwable x)
         {
             if (active != null)
                 active.failed(x);

jetty-core/jetty-http2/jetty-http2-common/src/main/java/org/eclipse/jetty/http2/internal/HTTP2Flusher.java

@@ -344,7 +344,7 @@ protected void onCompleteSuccess()
     }
 
     @Override
-    protected void onCompleteFailure(Throwable x)
+    protected void onFailure(Throwable x)
     {
         release();
 

jetty-core/jetty-http2/jetty-http2-tests/src/test/java/org/eclipse/jetty/http2/tests/RawHTTP2ProxyTest.java

@@ -519,7 +519,7 @@ protected void onSuccess()
         }
 
         @Override
-        protected void onCompleteFailure(Throwable cause)
+        protected void onFailure(Throwable cause)
         {
             frameInfo.callback.failed(cause);
         }
@@ -673,7 +673,7 @@ protected void onSuccess()
         }
 
         @Override
-        protected void onCompleteFailure(Throwable cause)
+        protected void onFailure(Throwable cause)
         {
             frameInfo.callback.failed(cause);
         }

jetty-core/jetty-http3/jetty-http3-common/src/main/java/org/eclipse/jetty/http3/ControlFlusher.java

@@ -122,7 +122,7 @@ protected void onSuccess()
     }
 
     @Override
-    protected void onCompleteFailure(Throwable failure)
+    protected void onFailure(Throwable failure)
     {
         if (LOG.isDebugEnabled())
             LOG.debug("failed to write {} on {}", entries, this, failure);

jetty-core/jetty-http3/jetty-http3-common/src/main/java/org/eclipse/jetty/http3/InstructionFlusher.java

@@ -118,7 +118,7 @@ protected void onCompleteSuccess()
     }
 
     @Override
-    protected void onCompleteFailure(Throwable failure)
+    protected void onFailure(Throwable failure)
     {
         if (LOG.isDebugEnabled())
             LOG.debug("failed to write buffers on {}", this, failure);

jetty-core/jetty-http3/jetty-http3-common/src/main/java/org/eclipse/jetty/http3/MessageFlusher.java

@@ -118,7 +118,7 @@ protected void onSuccess()
     }
 
     @Override
-    protected void onCompleteFailure(Throwable cause)
+    protected void onFailure(Throwable cause)
     {
         if (LOG.isDebugEnabled())
             LOG.debug("failed to write {} on {}", entry, this, cause);

jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/IOResources.java

@@ -413,12 +413,12 @@ protected void onCompleteSuccess()
         }
 
         @Override
-        protected void onCompleteFailure(Throwable x)
+        protected void onFailure(Throwable x)
         {
             if (retainableByteBuffer != null)
                 retainableByteBuffer.release();
             IO.close(channel);
-            super.onCompleteFailure(x);
+            super.onFailure(x);
         }
     }
 }

jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentCopier.java

@@ -77,13 +77,13 @@ protected Action process() throws Throwable
     }
 
     @Override
-    protected void onCompleteFailure(Throwable x)
+    protected void onFailure(Throwable x)
     {
         if (current != null)
         {
             current.release();
             current = Content.Chunk.next(current);
         }
-        ExceptionUtil.callAndThen(x, source::fail, super::onCompleteFailure);
+        ExceptionUtil.callAndThen(x, source::fail, super::onFailure);
     }
 }

jetty-core/jetty-quic/jetty-quic-common/src/main/java/org/eclipse/jetty/quic/common/QuicConnection.java

@@ -377,7 +377,7 @@ public InvocationType getInvocationType()
         }
 
         @Override
-        protected void onCompleteFailure(Throwable cause)
+        protected void onFailure(Throwable cause)
         {
             entry.callback.failed(cause);
             QuicConnection.this.close();

jetty-core/jetty-quic/jetty-quic-common/src/main/java/org/eclipse/jetty/quic/common/QuicSession.java

@@ -543,7 +543,7 @@ protected void onCompleteSuccess()
         }
 
         @Override
-        protected void onCompleteFailure(Throwable failure)
+        protected void onFailure(Throwable failure)
         {
             if (LOG.isDebugEnabled())
                 LOG.debug("failed to write cipher bytes, closing session on {}", QuicSession.this, failure);

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ConnectHandler.java

@@ -768,7 +768,7 @@ protected void onSuccess()
             }
 
             @Override
-            protected void onCompleteFailure(Throwable x)
+            protected void onFailure(Throwable x)
             {
                 if (LOG.isDebugEnabled())
                     LOG.debug("Failed to write {} bytes {}", filled, TunnelConnection.this, x);

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponseAndCallback.java

@@ -322,14 +322,14 @@ public GzipBufferCB(boolean complete, Callback callback, ByteBuffer content)
         }
 
         @Override
-        protected void onCompleteFailure(Throwable x)
+        protected void onFailure(Throwable x)
         {
             if (_deflaterEntry != null)
             {
                 _deflaterEntry.release();
                 _deflaterEntry = null;
             }
-            super.onCompleteFailure(x);
+            super.onFailure(x);
         }
 
         @Override

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java

@@ -910,7 +910,7 @@ protected void onCompleteSuccess()
         }
 
         @Override
-        public void onCompleteFailure(final Throwable x)
+        public void onFailure(final Throwable x)
         {
             failedCallback(release(), x);
         }

jetty-core/jetty-tests/jetty-test-client-transports/src/test/java/org/eclipse/jetty/test/client/transport/CustomTransportTest.java

@@ -335,7 +335,7 @@ protected void onCompleteSuccess()
             }
 
             @Override
-            protected void onCompleteFailure(Throwable cause)
+            protected void onFailure(Throwable cause)
             {
                 // There was a write error, close the Gateway Channel.
                 channel.close(cause);
@@ -378,7 +378,7 @@ protected void onCompleteSuccess()
             }
 
             @Override
-            protected void onCompleteFailure(Throwable cause)
+            protected void onFailure(Throwable cause)
             {
                 // There was a write error, close the Gateway Channel.
                 channel.close(cause);