Fix #11290 empty field (#11291)

Fixed cacheable empty field for #11290
jetty · Jan 18, 2024 · a2d86c7 · a2d86c7
1 parent 8cc7abe
commit a2d86c7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java b/jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpParser.java
@@ -2128,7 +2128,7 @@ else if (!_cache.put(field))
 
         public boolean cacheable(HttpHeader header, String valueString)
         {
-            return isEnabled() && header != null && valueString.length() <= _size;
+            return isEnabled() && header != null && valueString != null && valueString.length() <= _size;
         }
 
         private void prepare()

diff --git a/jetty-core/jetty-http/src/test/java/org/eclipse/jetty/http/HttpParserTest.java b/jetty-core/jetty-http/src/test/java/org/eclipse/jetty/http/HttpParserTest.java
@@ -557,12 +557,23 @@ public void testNoValue(String eoln)
         ByteBuffer buffer = BufferUtil.toBuffer(
             "GET / HTTP/1.0" + eoln +
                 "Host: localhost" + eoln +
-                "Name0: " + eoln +
+                "Name0:  " + eoln +
                 "Name1:" + eoln +
+                "Authorization:  " + eoln +
+                "Authorization:" + eoln +
                 eoln);
 
-        HttpParser.RequestHandler handler = new Handler();
+        HttpParser.RequestHandler handler = new Handler()
+        {
+            @Override
+            public void badMessage(HttpException failure)
+            {
+                ((Throwable)failure).printStackTrace();
+                super.badMessage(failure);
+            }
+        };
         HttpParser parser = new HttpParser(handler);
+        parser.setHeaderCacheSize(1024);
         parseAll(parser, buffer);
 
         assertTrue(_headerCompleted);
@@ -576,7 +587,11 @@ public void testNoValue(String eoln)
         assertEquals("", _val[1]);
         assertEquals("Name1", _hdr[2]);
         assertEquals("", _val[2]);
-        assertEquals(2, _headers);
+        assertEquals("Authorization", _hdr[3]);
+        assertEquals("", _val[3]);
+        assertEquals("Authorization", _hdr[4]);
+        assertEquals("", _val[4]);
+        assertEquals(4, _headers);
     }
 
     @ParameterizedTest