Skip to content

Commit

Permalink
Fix #5937
Browse files Browse the repository at this point in the history
updates from review.
  • Loading branch information
gregw committed Feb 5, 2021
1 parent 39f6f87 commit ed534b8
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -745,15 +745,6 @@ public boolean isError()
}
}

public Throwable getError()
{
synchronized (_inputQ)
{
Throwable error = _state instanceof ErrorState ? ((ErrorState)_state)._error : null;
return error == null ? new IOException() : error;
}
}

public boolean isAsync()
{
synchronized (_inputQ)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ public void complete(Callback callback)
case BLOCKED:
case UNREADY:
case PENDING:
LOG.warn("Pending write onComplated {} {}", this, _channel);
LOG.warn("Pending write in complete {} {}", this, _channel);
// An operation is in progress, so we soft close now
_softClose = true;
// then trigger a close from onWriteComplete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1884,7 +1884,7 @@ protected void recycle()

getHttpChannelState().recycle();
_requestAttributeListeners.clear();
// Defer _input.recycle() until setMetaData on next request, so that late readers will fail
// Defer _input.recycle() until setMetaData on next request, TODO replace with recycle and reopen in 10
_metaData = null;
_originalURI = null;
_contextPath = null;
Expand Down

0 comments on commit ed534b8

Please sign in to comment.