Fix #10229 EE10 Idle Timeout

Possible fix
jetty · Aug 4, 2023 · fe1aabc · fe1aabc
1 parent c506502
commit fe1aabc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.../jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletRequestState.java b/.../jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletRequestState.java
@@ -735,9 +735,7 @@ public boolean onIdleTimeout(TimeoutException timeout)
         {
             if (LOG.isDebugEnabled())
                 LOG.debug("onIdleTimeout {}", getStatusStringLocked(), timeout);
-            // TODO this is almost always returning false?!? what about read/write timeouts???
-            //      return _state == State.IDLE;
-            return true;
+            return _state == State.IDLE;
         }
     }
 

diff --git a/jetty-ee10/jetty-ee10-servlet/src/test/java/org/eclipse/jetty/ee10/servlet/ServletTest.java b/jetty-ee10/jetty-ee10-servlet/src/test/java/org/eclipse/jetty/ee10/servlet/ServletTest.java
@@ -88,7 +88,7 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws Se
             {
                 try
                 {
-                    Thread.sleep(2000);
+                    Thread.sleep(1000);
                 }
                 catch (InterruptedException e)
                 {