Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty10 inetaccess mod started error #10388

Closed
james-z-repo opened this issue Aug 24, 2023 · 1 comment · Fixed by #10400
Closed

Jetty10 inetaccess mod started error #10388

james-z-repo opened this issue Aug 24, 2023 · 1 comment · Fixed by #10400
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@james-z-repo
Copy link

james-z-repo commented Aug 24, 2023

Jetty version(s)

10.0.152
Jetty Environment

Java version/vendor (use: java -version)
JDK8
OS type/version
win10
Description

the jetty-inetaccess.xml has invoke includeConnectors method,but when i used inetaccess mod, the InetAccessHandler has a Exception:

@deprecated
public void includeConnectors(String... names)
{
throw new UnsupportedOperationException();
}

excludeConnectors javac is wrong , should write exclude()
How to reproduce?

@james-z-repo james-z-repo added the Bug For general bugs on Jetty side label Aug 24, 2023
@lachlan-roberts
Copy link
Contributor

I can reproduce this, the module is broken because it is using the deprecated includeConnectors and excludeConnectors methods from the XML.

You can override and modify the jetty-inetaccess.xml in your jetty-base if you want a quick workaround. You will just need to use include(name+"@") instead.

I will put up a PR to get this fixed.

lachlan-roberts added a commit that referenced this issue Aug 25, 2023
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Aug 25, 2023
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts linked a pull request Aug 25, 2023 that will close this issue
lachlan-roberts added a commit that referenced this issue Aug 25, 2023
sbordet added a commit that referenced this issue Aug 25, 2023
Issue #10388 - fix InetAccessHandler module

Add DistributionTest for InetAccessHandler
Removed deprecated method from InetAccessHandler.
Fixed InetAccessHandler DistributionTests for 12.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants