Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JettyWebSocketFrameHandler incorrectly relies on autoDemand when handlers are not registered #11303

Closed
lorban opened this issue Jan 23, 2024 · 0 comments · Fixed by #11304
Closed

JettyWebSocketFrameHandler incorrectly relies on autoDemand when handlers are not registered #11303

lorban opened this issue Jan 23, 2024 · 0 comments · Fixed by #11304
Assignees
@lorban
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Milestone
12.0.x

Comments

@lorban
Copy link
Contributor

lorban commented Jan 23, 2024

Jetty version(s)
12.0.5

Jetty Environment
All

Description
When autoDemand is configured to false, JettyWebSocketFrameHandler mistakenly relies on it when it should not for the cases where no handler is registered.

E.g.: if no openHandle is registered, we should always demand no matter what the autoDemand is configured to. The same is valid for ping frames too.
@lorban lorban added Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement labels Jan 23, 2024
@lorban lorban added this to the 12.0.x milestone Jan 23, 2024
@lorban lorban self-assigned this Jan 23, 2024
@lorban lorban moved this to 🏗 In progress in Jetty 12.0.6 FROZEN Jan 23, 2024
lorban added a commit that referenced this issue Jan 23, 2024
@lorban
#11303 fix incorrect reliance on autoDemand when handlers are not con…
95cd5a3 
…figured

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban mentioned this issue Jan 23, 2024
Merged
lorban added a commit that referenced this issue Jan 23, 2024
@lorban
#11303 fix incorrect test
499b82f 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Jan 23, 2024
@lorban
#11303 handle review comments
724f929 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Jan 24, 2024
@lorban
Fix incorrect reliance on autoDemand when handlers are not configured (…
aa3873f 
…#11304)

#11303 fix incorrect reliance on autoDemand when handlers are not configured

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.6 FROZEN Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.6 FROZEN
Status: ✅ Done
Milestone
12.0.x
Development

Successfully merging a pull request may close this issue.

Fix incorrect reliance on autoDemand when handlers are not configured jetty/jetty.project
1 participant
@lorban