Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve differences in EE9/EE10/Core AliasCheckerSymlinkTests #11434

Closed
lachlan-roberts opened this issue Feb 22, 2024 · 0 comments · Fixed by #12208
Closed

resolve differences in EE9/EE10/Core AliasCheckerSymlinkTests #11434

lachlan-roberts opened this issue Feb 22, 2024 · 0 comments · Fixed by #12208
Assignees
@lachlan-roberts
Labels
Enhancement Test

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version(s)
12

Enhancement Description
We have AliasCheckerSymlinkTest for EE9/EE10 and Jetty Core.

The EE10 version is the most up-to-date with the latest tests, but the Jetty Core and EE9 versions have not been updated.

The EE10 and Jetty Core versions are both testing the same thing so I think we only need one of those.

EE9 checks aliases in the nested ContextHandler so I think we still need to keep this one.
@lachlan-roberts lachlan-roberts self-assigned this Feb 22, 2024
lachlan-roberts added a commit that referenced this issue Aug 28, 2024
@lachlan-roberts
Issue #11434 - resolve differences in AliasCheckerSymlinkTests
178a795 
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
@lachlan-roberts lachlan-roberts mentioned this issue Aug 28, 2024
Merged
lachlan-roberts added a commit that referenced this issue Aug 28, 2024
@lachlan-roberts
Issue #11434 - remove printlns in AliasCheckerSymlinkTest
96a0468 
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
lachlan-roberts added a commit that referenced this issue Sep 3, 2024
@lachlan-roberts
Merge pull request #12208 from jetty/jetty-12.0.x-11434-AliasCheckerS…
899c005 
…ymlinkTests

Issue #11434 - resolve differences in AliasCheckerSymlinkTests
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.13 - FROZEN Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Enhancement Test
Projects
No open projects
Jetty 12.0.13 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #11434 - resolve differences in AliasCheckerSymlinkTests jetty/jetty.project
1 participant
@lachlan-roberts