Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Jetty 10 changes to Websocket #1165

Closed
WalkerWatch opened this issue Dec 12, 2016 · 6 comments
Closed

Document Jetty 10 changes to Websocket #1165

WalkerWatch opened this issue Dec 12, 2016 · 6 comments
Assignees

Comments

@WalkerWatch
Copy link
Contributor

Update documentation for Websocket to reflect 9.4 changes.

Includes:

  • HttpClient Integration
  • WebSocketUpgradeFilter used in WEB-INF/web.xml
@WalkerWatch
Copy link
Contributor Author

Closing for now until Websocket changes are finished.

@joakime joakime reopened this Aug 23, 2017
@joakime
Copy link
Contributor

joakime commented Aug 23, 2017

Discussing some important changes in 9.4.7 with @sbordet that will definitely need to be documented.

Add Configuring WebSocketClient on JSR356 to the list.

@sbordet
Copy link
Contributor

sbordet commented Sep 26, 2017

@WalkerWatch I think this issue should be renamed, as the changes are now happening on 10.0.x ?

@WalkerWatch WalkerWatch changed the title Document 9.4 changes to Websocket Document Jetty 10 changes to Websocket Sep 26, 2017
@lachlan-roberts
Copy link
Contributor

Just looked through the current WebSocket documentation in jetty-10.0.x and picked up a few things which should be updated because of the recent changes.

Enabling WebSocket

  • enable key should be org.eclipse.jetty.websocket.javax not org.eclipse.jetty.websocket.jsr356 which is now deprecated
  • org.eclipse.jetty.websocket.jsr356.server.deploy.WebSocketServerContainerInitializer does not exist anymore, that would be org.eclipse.jetty.websocket.javax.server.JavaxWebSocketServletContainerInitializer

WebSocket Session

  • session.getRemoteAddress() now returns only SocketAddress not InetSocketAddress
  • session.setIdleTimeout(long) now takes Duration

Send Messages to Remote Endpoint

  • Async Send Message
    • sendByFuture methods are now deprecated, use the methods taking WriteCallback instead

Jetty WebSocket Server API

  • JettyWebSocketServlet instead of WebSocketServlet
  • JettyWebSocketCreator instead of WebSocketCreator
  • JettyWebSocketServletFactory instead of WebSocketServletFactory
  • broken link on bottom of page

@lachlan-roberts
Copy link
Contributor

@WalkerWatch do you want me to work on make these changes

lachlan-roberts added a commit that referenced this issue Oct 10, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts pushed a commit that referenced this issue Oct 17, 2019
* Updating Websocket documentation for Jetty 10 per #1165

* Issue #1165 - updating documentation with WriteCallback async examples

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

* Grammatical changes.
@WalkerWatch
Copy link
Contributor Author

Fixed with #4172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants