-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QosHandler suspend queue limit #12185
Labels
Bug
For general bugs on Jetty side
Comments
Yes please. |
LarsKrogJensen
added a commit
to LarsKrogJensen/jetty.project-issue-12185
that referenced
this issue
Aug 22, 2024
PR ready for review |
LarsKrogJensen
added a commit
to LarsKrogJensen/jetty.project-issue-12185
that referenced
this issue
Aug 22, 2024
LarsKrogJensen
added a commit
to LarsKrogJensen/jetty.project-issue-12185
that referenced
this issue
Aug 22, 2024
LarsKrogJensen
added a commit
to LarsKrogJensen/jetty.project-issue-12185
that referenced
this issue
Aug 22, 2024
LarsKrogJensen
added a commit
to LarsKrogJensen/jetty.project-issue-12185
that referenced
this issue
Aug 22, 2024
Fixed by #12189. |
sbordet
pushed a commit
that referenced
this issue
Aug 23, 2024
sbordet
pushed a commit
that referenced
this issue
Aug 23, 2024
sbordet
pushed a commit
that referenced
this issue
Aug 23, 2024
sbordet
pushed a commit
that referenced
this issue
Aug 23, 2024
sbordet
pushed a commit
that referenced
this issue
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
12.0.11
Jetty Environment
ee10
Java version/vendor
(use: java -version)
java 21.0.3 2024-04-16 LTS
Java(TM) SE Runtime Environment Oracle GraalVM 21.0.3+7.1 (build 21.0.3+7-LTS-jvmci-23.1-b37)
Java HotSpot(TM) 64-Bit Server VM Oracle GraalVM 21.0.3+7.1 (build 21.0.3+7-LTS-jvmci-23.1-b37, mixed mode, sharing)
OS type/version
Ubuntu 22.04
Description
We are using QoSHandler to protect app from being flooded with requests, but had an incident with a combination slow backend and sudden big increase in requests causing suspend queue to grow without a limit and finally OOM:ed. AWS auto scaling could not scale out quick enough, all instances died.
Suggestion is to have similar limit check to suspended requests as already exists for max active requests to prevent this scenario.
Happy to provide a PR if you consider this a valid feature of QoSHandler.
The text was updated successfully, but these errors were encountered: