Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty Maven Plugin 12.x no longer configures DefaultHandler #12207

Closed
basil opened this issue Aug 28, 2024 · 0 comments · Fixed by #12211
Closed

Jetty Maven Plugin 12.x no longer configures DefaultHandler #12207

basil opened this issue Aug 28, 2024 · 0 comments · Fixed by #12211
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@basil
Copy link
Contributor

basil commented Aug 28, 2024

Jetty version(s)
12.0.12

Jetty Environment
EE 8

Java version/vendor (use: java -version)
OpenJDK version 17.0.12 2024-07-16

OS type/version
Ubuntu 22.04.4 LTS x86_64

Description

Jetty Maven Plugin 10.x displayed a nice DefaultHandler listing known contexts when the user visited the root URL. Jetty 12.x no longer does this, and one of our developers complained about this in JENKINS-73608.

In 10.x, DefaultHandler was instantiatied via eclipse.jetty.maven.ServerSupport#configureHandlers. As of #9305 in 12.x, the same method no longer instantiates DefaultHandler, and nothing else instantiates it, either. Note that #9305 failed to update the method's Javadoc, which (now incorrectly) states:

Also put in a DefaultHandler so we get a nicer page than a 404 if we hit the root and the webapp's context isn't at root.

How to reproduce?

$ git clone https://github.com/jenkinsci/jenkins.git
$ mvn clean install -Pquick-build
$ mvn -pl war jetty:run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants