Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default session configuration parameter flushOnResponseCommit to true rather than false #12339

Closed
janbartel opened this issue Oct 2, 2024 · 1 comment
Closed

Default session configuration parameter flushOnResponseCommit to true rather than false #12339

janbartel opened this issue Oct 2, 2024 · 1 comment
Assignees
@janbartel
Labels
Enhancement

Comments

@janbartel
Copy link
Contributor

Jetty version(s)
12.1.x

The AbstractSessionCache/AbstractSessionCacheFactory config parameter flushOnResponseCommit is used to determine whether we need to have fully saved the session before the response is returned to the client. The default is false. It may make more sense to default it to true so the default is that a session is fully saved before the response is returned to the client.
@janbartel janbartel self-assigned this Oct 2, 2024
janbartel added a commit that referenced this issue Oct 3, 2024
@janbartel
Issue #12339 change SessionCache default flushOnResponseCommit=true
0d43708
@janbartel janbartel mentioned this issue Oct 3, 2024
Merged
janbartel added a commit that referenced this issue Oct 8, 2024
@janbartel
Issue #12339 change SessionCache default flushOnResponseCommit=true (#…
f8ff191 
…12344)

* Issue #12339 change SessionCache default flushOnResponseCommit=true
@janbartel
Copy link
Contributor Author

Fixed by #12344

@github-project-automation github-project-automation bot moved this to ✅ Done in Jetty 12.1.0 Oct 8, 2024
@olamy olamy mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Enhancement
Projects
Jetty 12.1.0
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janbartel