Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientTransportDynamic does not initialize low-level clients #12348

Closed
sbordet opened this issue Oct 4, 2024 · 0 comments · Fixed by #12349
Closed

HttpClientTransportDynamic does not initialize low-level clients #12348

sbordet opened this issue Oct 4, 2024 · 0 comments · Fixed by #12349
Assignees
@sbordet
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Oct 4, 2024

Jetty version(s)
12

Description
Both HttpClientTransportOverHTTP[2|3] initialize the low-level client in their doStart(), but HttpClientTransportDynamic does not.

For example, calling HttpClient.setMaxResponseHeadersSize() is not forwarded to HTTP2Client when using HttpClientTransportDynamic.
@sbordet sbordet added the Bug For general bugs on Jetty side label Oct 4, 2024
@sbordet sbordet self-assigned this Oct 4, 2024
sbordet added a commit that referenced this issue Oct 4, 2024
@sbordet
Fixes #12348 - HttpClientTransportDynamic does not initialize low-lev…
3f903e2 
…el clients.

Fixed initialization for HTTP/2 and HTTP/3.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Oct 4, 2024 that will close this issue
Fixes #12348 - HttpClientTransportDynamic does not initialize low-level clients. #12349
Merged
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.15 FROZEN Oct 4, 2024
sbordet added a commit that referenced this issue Oct 10, 2024
@sbordet
Fixes #12348 - HttpClientTransportDynamic does not initialize low-lev…
f2c70fb 
…el clients. (#12349)

Fixed initialization for HTTP/2 and HTTP/3.
Fixed test that was relying on default configuration, rather than explicit.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.15 FROZEN Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.15 FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #12348 - HttpClientTransportDynamic does not initialize low-level clients. jetty/jetty.project
1 participant
@sbordet