New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated classes & methods #1676

Closed

gregw opened this issue Jul 18, 2017 · 12 comments

Milestone

Contributor

gregw commented Jul 18, 2017

There are several classes and many methods deprecated in jetty-9.4.x. Should these be remove in Jetty-10.x?

IPAddressMap
PathMap
FileResource
...

gregw added this to the 10.0.x milestone

Contributor Author

gregw commented Jul 18, 2017

Any reason why not? @sbordet @janbartel @joakime @jmcc0nn3ll @WalkerWatch @olamy ?

Contributor

jmcc0nn3ll commented Jul 18, 2017

Jetty 10 would be the proper time and place, yes.

Member

olamy commented Jul 18, 2017 via email

If deprecated in 9.4 no reason to not remove

On Tue, 18 Jul 2017 at 10:37 pm, Jesse McConnell ***@***.***> wrote: Jetty 10 would be the proper time and place, yes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1676 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABNELNU7y6VPc800wsXxQ5FNEWzU4gIks5sPKbrgaJpZM4ObMUp> .

-- Olivier

Contributor

WalkerWatch commented Jul 18, 2017

+1 for removal in 10.x - would like a full list once we do this so we can include in migration guide(s).

Contributor

joakime commented Jul 18, 2017

Would also encourage use of the new @deprecated annotation in Java 9 for those methods that cannot be removed (yet).

There will also be some existing @deprecated methods that cannot be removed (such as the Request.getRealPath(String))

gregw added a commit that referenced this issue


          Issue #1676 Removed deprecated module jetty-continuations

79cafb3

Contributor Author

gregw commented Jul 18, 2017

@WalkerWatch I'll do the removal commit by commit, so git will tell us the complete list.
I just removed jetty-continuations.... what a historic step!

Contributor

joakime commented Jul 18, 2017

@gregw btw, this is a duplicate of Issue #616

gregw added a commit that referenced this issue


          Issue #1676 removed deprecated IPAddressMap and IPAccessHandler. Crea…

3a4da94

…ted module inetaccess.mod

gregw mentioned this issue

Remove all deprecated classes and methods for Jetty 10.x #616

Closed

gregw added a commit that referenced this issue


          Issue #1676 removed deprecated PathMap

34b25ff

gregw added a commit that referenced this issue


          Issue #1676 removed deprecated FileResource

134dfd3

gregw added a commit that referenced this issue


          Issue #1676 complete removal of completions

0acd68e

gregw added a commit that referenced this issue


          Issue #1676 remove deprecated SelectChannelEndPoint

a53222c

gregw added a commit that referenced this issue


          Issue #1676 remove deprecated HttpParser STRICT system property

d14c53e

gregw added a commit that referenced this issue


          Issue #1676 remove deprecated methods on HttpFields

5a05e95

gregw added a commit that referenced this issue


          Issue #1676 remove deprecated methods on HttpFields

f114685

gregw added a commit that referenced this issue


          Issue #1676 remove deprecated methods from WebAppContext

2443ca3

Contributor

joakime commented Jul 19, 2017

Should we remove the deprecated="<property>" attributes from the xml files too?

eg:

<Set name="host"><Property name="jetty.ssl.host" deprecated="jetty.host" /></Set>

https://github.com/eclipse/jetty.project/blob/jetty-9.4.6.v20170531/jetty-server/src/main/config/etc/jetty-ssl.xml#L29

Contributor

jmcc0nn3ll commented Jul 19, 2017

+1

Contributor Author

gregw commented Jul 19, 2017 via email

OK will do....

On 19 July 2017 at 16:13, Jesse McConnell ***@***.***> wrote: +1 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1676 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEUrX9J4UMYF2GfCRvwhIVhlo4Ftv_wks5sPg6pgaJpZM4ObMUp> .

-- Greg Wilkins <gregw@webtide.com> CTO http://webtide.com

gregw added a commit that referenced this issue


          Issue #1676 remove deprecated properties from XML

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated methods and classes

336ef02

Signed-off-by: Joakim Erdfelt <joakim@erdfelt.com>

joakime added a commit that referenced this issue


          Issue #1676 - Cleaning up test cases and javadoc

d2dc230

Signed-off-by: Joakim Erdfelt <joakim@erdfelt.com>

joakime added a commit that referenced this issue


          Issue #1676 - Cleaning up .valueOf() usages

038f750

Signed-off-by: Joakim Erdfelt <joakim@erdfelt.com>

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated LocalConnector methods

ec42107

Signed-off-by: Joakim Erdfelt <joakim@erdfelt.com>

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated methods and classes

0a8297c

+ Cleaning up test cases and javadoc
+ Cleaning up .valueOf() usages

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime mentioned this issue

Cleanup QuotedQualityCSV internal use of Double #3404

Closed

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated MultiPartCompliance configs

85a725a

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Correcting double declarations

d7124c0

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Correcting double declarations

6d9f4cc

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated methods and classes

+ Changing usages of JVM deprecated classes / methods as well
+ Cleaning up test cases and javadoc

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Correcting test cases that rely on removed methods/classes

783b022

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated properties from XML

ddf9685

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Revert: Issue #1676 - Reverting removal of JASPI BasicAuthModule

fc2a321

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Revert: Issue #1676 - Correcting more deprecated blockingTimeout usages

13719ab

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated methods and classes

205f4ff

+ Changing usages of JVM deprecated classes / methods as well
+ Cleaning up test cases and javadoc

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Removing test methods that rely on deprecated and now r…

118fa51

…emoved concepts

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Addressing OSGi deprecations

65bd37f

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #1676 - Removing deprecated methods and classes

e476cec

+ Changing usages of JVM deprecated classes / methods as well
+ Cleaning up test cases and javadoc
+ Removing test methods that rely on deprecated and now removed concepts

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Merge pull request #3398 from eclipse/jetty-10.0.x-remove-deprecated

ce3f663

Issue #1676 - Removing deprecated methods and classes

joakime added a commit that referenced this issue


          Issue #1676 - Removing Deprecated Resource.getURL()

418cae2

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

Contributor

joakime commented Mar 1, 2019

Opened PR #3416 to handle the removal of Resource.getURL()

joakime added a commit that referenced this issue


          Issue #1676 - Removing Deprecated Resource.getURL()

5658bf9

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Merge pull request #3416 from eclipse/jetty-10.0.x-1676-removing-reso…

a1567e0

…urce-geturl

Issue #1676 - Removing Deprecated Resource.getURL()

Contributor

joakime commented Mar 1, 2019

Considering this complete

joakime closed this as completed

gregw mentioned this issue

Issue #3012 refactored HttpCompliance #3435

Merged

joakime changed the title ~~Remove Deprecated classes & methods?~~ Remove Deprecated classes & methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment