Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review LowResourceMonitor #1919

Closed
sbordet opened this issue Oct 24, 2017 · 0 comments
Closed

Review LowResourceMonitor #1919

sbordet opened this issue Oct 24, 2017 · 0 comments
Assignees
@gregw

Comments

@sbordet
Copy link
Contributor

sbordet commented Oct 24, 2017

After #1732, LowResourceMonitor has few problems:

  • The class Javadoc states that if setAcceptingInLowResources() is set to true, then no new connections are accepted, but this contradicts what the method name says
  • isAcceptingInLowResources() is never used; a call to connector.setAccepting(false) is hardcoded in setLowResources()
@gregw gregw closed this as completed in 6e94d40 Oct 24, 2017
gregw added a commit that referenced this issue Nov 2, 2017
@gregw
Issue #1919 scalable scheduler
5408218 
Used the CyclicTimeoutTask class in the clients HttpDestination and HttpConnection
as an alternative to direct scheduler usage.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Nov 3, 2017
@gregw
Issue #1919 scalable scheduler
33bd7de 
Avoid race between compare and set by allowing reschedule to always set the timer

Signed-off-by: Greg Wilkins <gregw@webtide.com>
sbordet pushed a commit that referenced this issue Dec 19, 2017
@gregw @sbordet
Issue #1919 scalable scheduler
969bd67 
Used the CyclicTimeoutTask class in the clients HttpDestination and HttpConnection
as an alternative to direct scheduler usage.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
sbordet pushed a commit that referenced this issue Dec 19, 2017
@gregw @sbordet
Issue #1919 scalable scheduler
f82715f 
Avoid race between compare and set by allowing reschedule to always set the timer

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregw @sbordet