Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move server classes and dependencies out from websocket-core #2173

Closed
joakime opened this issue Jan 31, 2018 · 3 comments · Fixed by #4881
Closed

Move server classes and dependencies out from websocket-core #2173

joakime opened this issue Jan 31, 2018 · 3 comments · Fixed by #4881
Assignees
@joakime @lachlan-roberts
Milestone
10.0.x

Comments

@joakime
Copy link
Contributor

joakime commented Jan 31, 2018

Currently, websocket-core has server classes and dependencies.

These are not appropriate for websocket-core as they contaminate the dependency tree for both websocket clients.

These classes, test cases, and dependencies should be moved out of websocket-core
@joakime joakime self-assigned this Jan 31, 2018
@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activit. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@gregw gregw removed the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@gregw
Copy link
Contributor

gregw commented Nov 20, 2019

I think we are OK with the current package structure? Can this be closed?

@sbordet
Copy link
Contributor

sbordet commented Nov 20, 2019

I reported that some .internal. classes were present in signatures of public classes.

Not sure this is the right issue though. @lachlan-roberts?

@lachlan-roberts lachlan-roberts added this to the 10.0.x milestone Jan 30, 2020
@lachlan-roberts lachlan-roberts mentioned this issue Jan 30, 2020
Closed
lachlan-roberts added a commit that referenced this issue May 12, 2020
@lachlan-roberts
Issue #2173 & #2174 - Split websocket-core into client/server/common …
11d14a6 
…modules

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue May 15, 2020
Merged
lachlan-roberts added a commit that referenced this issue May 25, 2020
@lachlan-roberts
Merge pull request #4881 from eclipse/jetty-10.0.x-WebSocketCoreRefactor
94c8edc 
Issue #2173 & #2174 - separate out client and server parts of websocket-core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
10.0.x
Development

Successfully merging a pull request may close this issue.

Separate out websocket client and server components from websocket-core jetty/jetty.project
4 participants
@gregw @joakime @sbordet @lachlan-roberts