Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure users of the jetty-websocket-api do not have to see websocket-core classes #3458

Closed
lachlan-roberts opened this issue Mar 13, 2019 · 0 comments
Closed

ensure users of the jetty-websocket-api do not have to see websocket-core classes #3458

lachlan-roberts opened this issue Mar 13, 2019 · 0 comments

Comments

@lachlan-roberts
Copy link
Contributor

in jetty 10.0.x

websocket-serlvet ServletUpgradeRequest and ServletUpgradeResponse relies on core classes as it is used by both the jetty and javax sides

so if a user of the jetty-api is providing a WebSocketCreator for the WebSocketMapping then they now need to know about the core implementation
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 13, 2019
@lachlan-roberts
Issue jetty#3458 - ExtensionConfig now delegates to core implementation
dc9459a 
ExtensionConfig is now interface in jetty-websocket-api and
implemented in jetty-websocket-common, for its static methods it now
uses a ExtensionConfig.Parser found by the ServiceLoader

the api tests were moved to jetty-websocket-tests

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 13, 2019
@lachlan-roberts
Issue jetty#3458 - jetty websocket upgrades with only jetty-server
dc142e0 
websocket-servlet exposes core classes as it is used by the jetty and
javax sides, so this introduces a way to add websocket mappings
with jetty-server which does not depend on websocket-servlet

to set websocket mappings through the JettyWebSocketServerContainer
you now need to use the JettyWebSocketCreator which abstracts away
the core classes from use with the jetty websocket api

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 13, 2019
@lachlan-roberts
Issue jetty#3458 - jetty websocket upgrades with only websocket-server
36b1b08 
websocket-servlet exposes core classes as it is used by the jetty and
javax sides, so this introduces a way to add websocket mappings
with jetty-server which does not depend on websocket-servlet

to set websocket mappings through the JettyWebSocketServerContainer
you now need to use the JettyWebSocketCreator which abstracts away
the core classes from use with the jetty websocket api

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Mar 13, 2019
Merged
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 13, 2019
@lachlan-roberts
Issue jetty#3458 - missing licence headers and changes from review
19d8c52 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 14, 2019
@lachlan-roberts
Issue jetty#3458 - testing of Jetty WebSocket API ExtensionConfig
b704dea 
wire up the jetty-api extensions by copying the ExtensionConfig from
the jetty-api upgrade request to the core upgrade request

make UpgradeListener interface methods default for convenience

introduce test to test the functionality of API ExtensionConfig

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 14, 2019
@lachlan-roberts
Issue jetty#3458 - testing of Jetty WebSocket API ExtensionConfig
0c1e34d 
wire up the jetty-api extensions by copying the ExtensionConfig from
the jetty-api upgrade request to the core upgrade request

make UpgradeListener interface methods default for convenience

introduce test to test the functionality of API ExtensionConfig

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 14, 2019
@lachlan-roberts
Issue jetty#3458 - testing of Jetty WebSocket API ExtensionConfig
89bee3f 
wire up the jetty-api extensions by copying the ExtensionConfig from
the jetty-api upgrade request to the core upgrade request

make UpgradeListener interface methods default for convenience

introduce test to test the functionality of API ExtensionConfig

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 17, 2019
@lachlan-roberts
Issue jetty#3458 - make jetty-websocket-client hide websocket-core
7aa6c62 
Signed-off-by: lachan-roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 18, 2019
@lachlan-roberts
Issue jetty#3458 - ExtensionConfig now delegates to core implementation
8667542 
ExtensionConfig is now interface in jetty-websocket-api and
implemented in jetty-websocket-common, for its static methods it now
uses a ExtensionConfig.Parser found by the ServiceLoader

the api tests were moved to jetty-websocket-tests

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 18, 2019
@lachlan-roberts
Issue jetty#3458 - jetty websocket upgrades with only websocket-server
f60534a 
websocket-servlet exposes core classes as it is used by the jetty and
javax sides, so this introduces a way to add websocket mappings
with jetty-server which does not depend on websocket-servlet

to set websocket mappings through the JettyWebSocketServerContainer
you now need to use the JettyWebSocketCreator which abstracts away
the core classes from use with the jetty websocket api

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 18, 2019
@lachlan-roberts
Issue jetty#3458 - missing licence headers and changes from review
62406cd 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 18, 2019
@lachlan-roberts
Issue jetty#3458 - testing of Jetty WebSocket API ExtensionConfig
20e9770 
wire up the jetty-api extensions by copying the ExtensionConfig from
the jetty-api upgrade request to the core upgrade request

make UpgradeListener interface methods default for convenience

introduce test to test the functionality of API ExtensionConfig

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 18, 2019
@lachlan-roberts
Issue jetty#3458 - make jetty-websocket-client hide websocket-core
dab3b64 
Signed-off-by: lachan-roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Mar 18, 2019
@gregw
Merge pull request #3460 from lachlan-roberts/jetty-10.0.x-3458-jetty…
012b9e5 
…WebSocket-API

Issue #3458 - jetty websocket upgrades without using websocket-servlet classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts