Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sending WebSocket close frame with error StatusCode does not do a hard close (Jetty-10) #3809

Closed
lachlan-roberts opened this issue Jun 24, 2019 · 0 comments
Closed

sending WebSocket close frame with error StatusCode does not do a hard close (Jetty-10) #3809

lachlan-roberts opened this issue Jun 24, 2019 · 0 comments
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Contributor

If a close frame sent through the session has an error close code such as SERVER_ERROR or ABNORMAL it is sent and a hard close of the connection is not done like it would be if it was created as an AbnormalCloseStatus.

Non transmittable status codes can also be sent in this way.
@lachlan-roberts lachlan-roberts self-assigned this Jun 24, 2019
lachlan-roberts added a commit that referenced this issue Jun 25, 2019
@lachlan-roberts
Issue #3809 - ensure abnormal close frame will hard close ws connection
fd5a11d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Jun 25, 2019
Merged
lachlan-roberts added a commit that referenced this issue Jul 1, 2019
@lachlan-roberts
Issue #3809 - ensure abnormal close frame will hard close ws connecti…
ac8910e 
…on (#3819)

* Issue #3809 - ensure abnormal close frame will hard close ws connection

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

* Issue #3159 - signal onError on abnormal status code close

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts