Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot configure maxFrameSize with javax websockets. #4148

Closed
lachlan-roberts opened this issue Oct 2, 2019 · 1 comment
Closed

Cannot configure maxFrameSize with javax websockets. #4148

lachlan-roberts opened this issue Oct 2, 2019 · 1 comment
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side
Milestone
10.0.x

Comments

@lachlan-roberts
Copy link
Contributor

websocket-core uses the maxFrameSize of the CoreSession to limit the size of data frames which can be received, this defaults to 65536. This cannot be configured through the javax API so cannot be changed from the default setting of 65536 which is too small for some of the autobahn tests causing them to fail.
@joakime joakime added this to the 10.0.x milestone Oct 2, 2019
@joakime joakime added the Bug For general bugs on Jetty side label Oct 2, 2019
@lachlan-roberts lachlan-roberts self-assigned this Oct 4, 2019
@lachlan-roberts lachlan-roberts mentioned this issue Oct 9, 2019
Merged
lachlan-roberts added a commit that referenced this issue Nov 12, 2019
@lachlan-roberts
Issue #4148 - config for jetty specific settings with javax WebSockets
2b2f685 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Nov 12, 2019
@lachlan-roberts
Issue #4148 - config for jetty specific settings with javax WebSockets
9c8780d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Nov 12, 2019
Merged
lachlan-roberts added a commit that referenced this issue Nov 13, 2019
@lachlan-roberts
Issue #4148 - support for EndpointConfig down casting and pathParams
b5abc32 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Dec 16, 2019
@lachlan-roberts
Issue #4148 - config for jetty specific settings with javax WebSockets (
ce6438c 
#4295)

* Issue #4148 - config for jetty specific settings with javax WebSockets

* Make every jetty EndpointConfig implementation a wrapper
* Remove BasicEndpointConfig and use Client or Server specific ones
@lachlan-roberts
Copy link
Contributor Author

Jetty specific websocket settings such as autoFragment, maxFrameSize, outputBufferSize and inputBufferSize can now be configured through EndpointConfig.getUserProperties() or Session.getUserProperties() since PR #4295 . Properties like org.eclipse.jetty.websocket.autoFragment can be set and this will call the appropriate setter on the CoreSesion.

@WalkerWatch maybe this is something worth adding to the jetty-10 documentation for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
2 participants
@joakime @lachlan-roberts