Verify WebSocket client behaviour for negotiation of internal extensions. #4349
Assignees
Comments
lachlan-roberts
added a commit
that referenced
this issue
Nov 25, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
added a commit
that referenced
this issue
Nov 25, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
added a commit
that referenced
this issue
Nov 29, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
added a commit
that referenced
this issue
Dec 1, 2019
Added tests for WebSocket client negotiation of requested internal extensions. Changed the algorithm to remove from the requested list rather than add to the negotiated one. Fixed other issues with the parsing of ExtensionConfig not giving correct errors for invalid content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version
10.0.x
Description
The websocket client must decide where in the list of extensions negotiated by the server its internal parameters should go.
The code to do this looks complicated and needs to be tested and explained in a comment.
https://github.com/eclipse/jetty.project/blob/2dbd19f9027625479571b8967f1e461aa816fc45/jetty-websocket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/client/ClientUpgradeRequest.java#L301-L309
The text was updated successfully, but these errors were encountered: