Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javax WebSocket encoder/decoders not working in jetty 10.0.x #4408

Closed
lachlan-roberts opened this issue Dec 9, 2019 · 0 comments
Closed
Assignees

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
This example of a basic javax websocket string decoder which appends a = character to the end of each message, works in 9.4.x but not 10.0.x.

public static class MyStringDecoder extends StringDecoder
{
    @Override
    public String decode(String s)
    {
        return s + "=";
    }
}

@ServerEndpoint(value = "/", decoders = {MyStringDecoder.class})
public static class ConfiguredEchoSocket
{
    ...
}

The tests for encoders/decoders really only test the decoders themselves and don't seem to test them live in a websocket connection. Testing for this should be improved and the implementation in 10.0.x should be fixed to maintain the correct behaviour.

@lachlan-roberts lachlan-roberts self-assigned this Dec 9, 2019
lachlan-roberts added a commit that referenced this issue Dec 9, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Dec 30, 2019
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant