Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate generation of servlets/filters/listeners from context xml with quickstart #4430

Closed
janbartel opened this issue Dec 19, 2019 · 0 comments · Fixed by #5311
Closed
Assignees

Comments

@janbartel
Copy link
Contributor

Jetty 10

Configuration that is applied by a context xml file can be generated into a quickstart-web.xml file. When the webapp is quickstarted, we apply both the context xml file AND the quickstart-web.xml file, which could lead to the same element being created/configured twice. I've tested this with a servlet that was defined in a context xml file: it was also generated into quickstart-web.xml file. Luckily, the StandardDescriptorProcessor that reads the quickstart-web.xml file has some protection in there for creating duplicate servlets, but it will reapply the configuration. I'm not sure of the situation with filters.

In any case, the solution would be to check the origin of the servlets/filters etc when generating the quickstart-web.xml file: any that were of programmatic/xml origin can be skipped, as they will be re-applied when the webapp is quickstarted.

@janbartel janbartel self-assigned this Dec 19, 2019
janbartel added a commit that referenced this issue Sep 22, 2020
…ext xml

Signed-off-by: Jan Bartel <janb@webtide.com>
gregw pushed a commit that referenced this issue Sep 22, 2020
…ext xml (#5311)

Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants