Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket-core is exposing internal classes #4450

Closed
lachlan-roberts opened this issue Dec 30, 2019 · 0 comments · Fixed by #4451
Closed

websocket-core is exposing internal classes #4450

lachlan-roberts opened this issue Dec 30, 2019 · 0 comments · Fixed by #4451
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description

Extension.java
Warning:(93, 34) java: class org.eclipse.jetty.websocket.core.internal.WebSocketCoreSession in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module

AbstractExtension.java
Warning:(172, 41) java: class org.eclipse.jetty.websocket.core.internal.WebSocketCoreSession in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module
Warning:(177, 15) java: class org.eclipse.jetty.websocket.core.internal.WebSocketCoreSession in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module

Negotiation.java
Warning:(187, 12) java: class org.eclipse.jetty.websocket.core.internal.ExtensionStack in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module

ClientUpgradeRequest.java
Warning:(275, 15) java: class org.eclipse.jetty.websocket.core.internal.WebSocketConnection in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module
Warning:(275, 148) java: class org.eclipse.jetty.websocket.core.internal.WebSocketCoreSession in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module
Warning:(280, 15) java: class org.eclipse.jetty.websocket.core.internal.WebSocketCoreSession in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module
Warning:(280, 82) java: class org.eclipse.jetty.websocket.core.internal.Negotiated in module org.eclipse.jetty.websocket.core may not be visible to all clients that require this module
@lachlan-roberts lachlan-roberts self-assigned this Dec 30, 2019
lachlan-roberts added a commit that referenced this issue Dec 30, 2019
@lachlan-roberts
Issue #4450 - websocket Extensions no longer rely upon WSCoreSession
0d571ef 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Dec 30, 2019
@lachlan-roberts
Issue #4450 - don't expose ExtensionStack through getter on Negotation
cf31ab2 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Dec 30, 2019
@lachlan-roberts
Issue #4450 - remove methods to create WS CoreSession and Connection
f1838c5 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Dec 30, 2019
Merged
sbordet added a commit that referenced this issue Jan 29, 2020
@sbordet
Merge pull request #4451 from eclipse/jetty-10.0.x-4450-WebSocketCore…
a682fe1 
…JPMS

Issue #4450 - websocket-core exposes internal classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4450 - websocket-core exposes internal classes jetty/jetty.project
1 participant
@lachlan-roberts