Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation extension should not downcast CoreSession #4515

Closed
lachlan-roberts opened this issue Jan 24, 2020 · 1 comment · Fixed by #5951
Closed

Validation extension should not downcast CoreSession #4515

lachlan-roberts opened this issue Jan 24, 2020 · 1 comment · Fixed by #5951
Assignees
@lachlan-roberts
Milestone
10.0.x

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
WebSocket validation extension should use static methods for validation instead of down casting the CoreSession.
@lachlan-roberts lachlan-roberts added this to the 10.0.x milestone Jan 24, 2020
@lachlan-roberts lachlan-roberts self-assigned this Jan 24, 2020
@lachlan-roberts lachlan-roberts mentioned this issue Jan 28, 2020
Merged
@stale
Copy link

stale bot commented Jan 23, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jan 23, 2021
lachlan-roberts added a commit that referenced this issue Feb 8, 2021
@lachlan-roberts
Issue #4515 - ValidationExtension should not downcast CoreSession
8bc84d3 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Feb 8, 2021
Merged
@lachlan-roberts lachlan-roberts removed the Stale For auto-closed stale issues and pull requests label Feb 8, 2021
lachlan-roberts added a commit that referenced this issue Feb 9, 2021
@lachlan-roberts
Merge pull request #5951 from eclipse/jetty-10.0.x-4515-WebSocketVali…
0fe4e78 
…dation

Issue #4515 - ValidationExtension should not downcast CoreSession
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
10.0.x
Development

Successfully merging a pull request may close this issue.

Issue #4515 - ValidationExtension should not downcast CoreSession jetty/jetty.project
1 participant
@lachlan-roberts