Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlConfiguration cleanup #4656

Closed
gregw opened this issue Mar 10, 2020 · 1 comment
Closed

XmlConfiguration cleanup #4656

gregw opened this issue Mar 10, 2020 · 1 comment
Assignees
@gregw

Comments

@gregw
Copy link
Contributor

gregw commented Mar 10, 2020 •
edited
Loading

Currently XmlConfiguration is a little irregular in what features can be attributes or elements. This needs to be generalised in 10.

See good description of needed changes in #4659
@gregw gregw self-assigned this Mar 10, 2020
@gregw gregw mentioned this issue Mar 10, 2020
Merged
@joakime
Copy link
Contributor

joakime commented Mar 10, 2020 •
edited
Loading

See also #4657 and #4658 and #4659

gregw added a commit that referenced this issue Mar 10, 2020
@gregw
Issue #4656 generalise XmlConfiguration elements
2f12ed7 
Extended the use of Id, Class elements

Signed-off-by: Greg Wilkins <gregw@webtide.com>
This was referenced Mar 10, 2020
Closed
Merged
joakime added a commit that referenced this issue Mar 12, 2020
@joakime
Issue #4656 - Fix bad xml id attribute usage in jetty-maven-plugin
c770f8a 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw added a commit that referenced this issue Mar 17, 2020
@gregw @joakime
Issue #4656 generalise XmlConfiguration elements (#4661)
e35b3b2 
* Issue #4656 generalise XmlConfiguration elements

Extended the use of Id, Class elements

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4657 Validation in XmlConfiguration

Default to validate if xerces is in the name
Fixed test harness to prepend DTD.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4657 Validation in XmlConfiguration

WIP on adding validation to XMLs

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4656 - Fix bad xml id attribute usage in jetty-maven-plugin

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@gregw gregw closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregw @joakime