Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncContext.dispatch does not remember the query string of the request #4713

Closed
janbartel opened this issue Mar 25, 2020 · 0 comments
Closed

AsyncContext.dispatch does not remember the query string of the request #4713

janbartel opened this issue Mar 25, 2020 · 0 comments
Assignees
@gregw
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@janbartel
Copy link
Contributor

jetty-10.0.x

TCK test com/sun/ts/tests/servlet/api/javax_servlet/asynccontext/URLClient.java#forwardTest1 fails. The test does a forward dispatch to a url like: "/AsyncTestServlet?testname=forwardDummy1". Inside the forward, Request.startAsync() is called followed by a AsyncContext.dispatch(). The URI that is used for the dispatch does not include the query string ?testname=forwardDummy1, causing the test to fail.
@janbartel janbartel added Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Mar 25, 2020
gregw added a commit that referenced this issue Mar 26, 2020
@gregw
Issue #4713 Async dispatch with query.
9831930 
+ Preserve the entire URI with query when startAsync(req,res) is used.
+ merge any query string from dispatch path with either original query or preserved query from forward

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw mentioned this issue Mar 26, 2020
Merged
gregw added a commit that referenced this issue Mar 30, 2020
@gregw
Issue #4713 asyncDispatch with query parameters
a74f36c 
Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Mar 30, 2020
@gregw
Issue #4713 Async dispatch with query. (#4721)
e3d670d 
* Issue #4713 Async dispatch with query.

+ Preserve the entire URI with query when startAsync(req,res) is used.
+ merge any query string from dispatch path with either original query or preserved query from forward

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4713 asyncDispatch with query parameters

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw closed this as completed Mar 30, 2020
gregw added a commit that referenced this issue Mar 31, 2020
@gregw
Issue #2074 no merge query string (#4730)
ef9e155 
* Issue #4713 Async dispatch with query.

+ Preserve the entire URI with query when startAsync(req,res) is used.
+ merge any query string from dispatch path with either original query or preserved query from forward

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #4713 asyncDispatch with query parameters

Signed-off-by: Greg Wilkins <gregw@webtide.com>

* Issue #2074 Do not merge query strings

Do not merge the query string itself, only the parameter map.
The query string is either the original or replaced by the one from the dispatch.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregw @janbartel