Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty-10 websocket-servlet exposes websocket-core classes #4722

Closed
lachlan-roberts opened this issue Mar 27, 2020 · 1 comment
Closed

Jetty-10 websocket-servlet exposes websocket-core classes #4722

lachlan-roberts opened this issue Mar 27, 2020 · 1 comment
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Contributor

lachlan-roberts commented Mar 27, 2020 •
edited
Loading

Jetty version
10.0.x

Description
websocket-servlet exposes websocket-core classes which are transitively exported through the other modules which require it.

It doesn't even look like websocket-servlet is really necessary at all. The WebSocketServlet and WebSocketServletFactory classes are only used for the websocket-jetty-server and nowhere in the javax implementation. The rest of the classes are to enable upgrades with the WebSocketUpgradeFilter, and these classes could be moved to websocket-util or websocket-core.
@lachlan-roberts lachlan-roberts self-assigned this Mar 27, 2020
lachlan-roberts added a commit that referenced this issue Mar 27, 2020
@lachlan-roberts
Issue #4722 - remove websocket-servlet
e0ba21e 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Mar 27, 2020
Merged
lachlan-roberts added a commit that referenced this issue Mar 27, 2020
@lachlan-roberts
Issue #4722 - remove websocket-servlet
89c4504 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Mar 29, 2020
@lachlan-roberts
Issue #4722 - fix typo in JavaxWebSocketConfiguration
9298883 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 16, 2020
@lachlan-roberts
Issue #4722 - changes from review
213e157 
- Fix packages exposed in the websocket configuration
- Make servlet dependency for websocket-util optional

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 19, 2020
@lachlan-roberts
Issue #4722 - fix build, websocket util exporting jetty servlet with …
e189691 
…jpms

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 22, 2020
@lachlan-roberts
Issue #4722 - create new module websocket-util-server
b586978 
- This module contains the WebSocketUpgradeFilter.
- Also has an internal package with the components used
  to implement websocket upgrades common to both the
  jetty and javax websocket implementations.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 22, 2020
@lachlan-roberts
Issue #4722 - fix typo for websocket-util-server jar
33a5db0 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue May 7, 2020
@lachlan-roberts
Merge pull request #4723 from eclipse/jetty-10.0.x-WebSocketServlet
2e1c01a 
Issue #4722 - remove websocket-servlet
@lachlan-roberts
Copy link
Contributor Author

The websocket-servlet module has been removed, the JettyWebSocketServlet is still present in the websocket-jetty-server module, and the common server classes and WebSocketUpgradeFilter have been moved to module websocket-util-server module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts