Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate websocket tck failures for jetty-10 #4747

Open
lachlan-roberts opened this issue Apr 3, 2020 · 0 comments
Open

Investigate websocket tck failures for jetty-10 #4747

lachlan-roberts opened this issue Apr 3, 2020 · 0 comments
Assignees
@lachlan-roberts
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
Currently 407 test failures for the jetty-10 websocket TCK run.
These should be investigated and fixed.
@lachlan-roberts lachlan-roberts added Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Apr 3, 2020
@lachlan-roberts lachlan-roberts self-assigned this Apr 3, 2020
lachlan-roberts added a commit that referenced this issue Apr 5, 2020
@lachlan-roberts
Issue #4747 - Default close status code should be normal status
664cb81 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 6, 2020
@lachlan-roberts
Issue #4747 - SessionID should return same String instance
2028b99 
Using the object hash code is not random enough to use as a unique ID.
Now using UUID.randomUUID() instead which sufficiently random.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 6, 2020
@lachlan-roberts
Issue #4747 - Throwing in onClose now calls onError
54ee3f3 
- This applies to the javax onClose method not the core onClosed method.
- Also fixes a bug where onClosed may never be called if onFrame throws.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Apr 7, 2020
Merged
lachlan-roberts added a commit that referenced this issue Apr 7, 2020
@lachlan-roberts
Issue #4747 - Fix WS path params to work within a context path
625dfd1 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 7, 2020
@lachlan-roberts
Issue #4747 - correctly copy headers in websocket JsrUpgradeListener
3d40e0e 
Headers with the same name may not have been copied properly for
header values inspected and modified with a Configurator.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 8, 2020
@lachlan-roberts
Issue #4747 - filter out synthetic annotated methods
4e69b48 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 9, 2020
@lachlan-roberts
Issue #4747 - server is allowed to not select a websocket subprotocol
45f822e 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 22, 2020
@lachlan-roberts
Issue #4747 - changes from review
c6e58e6 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 23, 2020
@lachlan-roberts
Merge pull request #4750 from eclipse/jetty-10.0.x-4747-WebSocketTCK
53246f9 
Issue #4747 - fix some test failures for jetty-10 with websocket tck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts