Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpSessionListener.sessionCreated should be called in order listener was added; sessionDestroyed in reverse order #4752

Closed
janbartel opened this issue Apr 7, 2020 · 0 comments · Fixed by #4753
Closed

HttpSessionListener.sessionCreated should be called in order listener was added; sessionDestroyed in reverse order #4752

janbartel opened this issue Apr 7, 2020 · 0 comments · Fixed by #4753
Assignees
@janbartel
Labels
TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@janbartel
Copy link
Contributor

Jetty calls all HttpSessionListener methods in reverse order that the listener was added. According to the javax.servlet.http.HttpSessionListener javadoc, sessionCreated() must be invoked in the order the listener was added, but sessionDestroyed() must be called in reverse order.

See https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/servlet/api/javax_servlet_http/servletcontext304/URLClient.java
@janbartel janbartel added the TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) label Apr 7, 2020
@janbartel janbartel self-assigned this Apr 7, 2020
janbartel added a commit that referenced this issue Apr 7, 2020
@janbartel
Issue #4752 Call HttpSessionListener.sessionCreated in add order.
ffe5a28 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel mentioned this issue Apr 7, 2020
Merged
janbartel added a commit that referenced this issue Apr 8, 2020
@janbartel
Issue #4752 Call HttpSessionListener.sessionCreated in add order. (#4753
efe2dc1 
)

Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Milestone
No milestone
1 participant
@janbartel