Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket DistributionTests failure on JDK14 #4800

Closed
lachlan-roberts opened this issue Apr 21, 2020 · 5 comments · Fixed by #4810
Closed

WebSocket DistributionTests failure on JDK14 #4800

lachlan-roberts opened this issue Apr 21, 2020 · 5 comments · Fixed by #4810

Comments

@lachlan-roberts
Copy link
Contributor

lachlan-roberts commented Apr 21, 2020 •
edited
Loading

Jetty version
10.0.x

Java version
OpenJDK 14.0.1

Description
Test failure for DistributionTests.testSimpleWebAppWithWebsocket():
https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/jetty-10.0.x/995/tests

2020-04-21 15:21:16.205:INFO :oejtd.DistributionTester:ConsoleStreamer/STDERR: java.lang.LinkageError: loader constraint violation: when resolving method 'void org.eclipse.jetty.tests.webapp.websocket.bad.BadOnOpenServerEndpoint.onOpen(javax.websocket.Session, org.eclipse.jetty.tests.webapp.websocket.bad.StringSequence)' the class loader 'bootstrap' of the current class, java/lang/Object, and the class loader org.eclipse.jetty.webapp.WebAppClassLoader @235a0c16 for the method's defining class, org/eclipse/jetty/tests/webapp/websocket/bad/BadOnOpenServerEndpoint, have different Class objects for the type org/eclipse/jetty/tests/webapp/websocket/bad/StringSequence used in the signature (java.lang.Object is in module java.base of loader 'bootstrap'; org.eclipse.jetty.tests.webapp.websocket.bad.BadOnOpenServerEndpoint is in unnamed module of loader org.eclipse.jetty.webapp.WebAppClassLoader @235a0c16, parent loader org.eclipse.jetty.start.Classpath$Loader @e6ea0c6)
lachlan-roberts added a commit that referenced this issue Apr 21, 2020
@lachlan-roberts
Issue #4800 - disable test DistributionTests.testSimpleWebAppWithWebs…
73382fe 
…ocket()

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 24, 2020
@lachlan-roberts
Issue #4800 - Reproduce LinkageError in WebSocket unit test
f5b0dc5 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 24, 2020
@lachlan-roberts
Issue #4800 - prevent LinkageErrors for WS lookup on JDK 14
870a765 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 24, 2020
@lachlan-roberts
Issue #4800 - invalid PathParam types should be reported at Deployment
fb85c71 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 24, 2020
@lachlan-roberts
Issue #4800 - test both cases individually
64beae3 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Apr 24, 2020
Merged
@lachlan-roberts lachlan-roberts linked a pull request Apr 24, 2020 that will close this issue
Issue #4800 - fix WebSocket LinkageError and invalid PathParam type handling #4810
Merged
lachlan-roberts added a commit that referenced this issue Apr 27, 2020
@lachlan-roberts
Issue #4800 - Improve WS DistributionTest to also test working webapp
c8a1dac 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@sbordet
Copy link
Contributor

sbordet commented Apr 29, 2020

See also: https://bugs.openjdk.java.net/browse/JDK-8244090 and discussion: https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-April/066089.html

lachlan-roberts added a commit that referenced this issue Apr 29, 2020
@lachlan-roberts
Issue #4800 - Revert MethodHandle changes & update DistributionTests
bf5d4ea 
- It seems it is correct to use the `MethodHandles.publicLookup().in()`
but this does not work if same webapp is deployed twice, so the
MethodHandle changes have been reverted and the test has been disabled
until a resolution to https://bugs.openjdk.java.net/browse/JDK-8244090.

- The DistributionTest has been changed to properly reproduce the issue.
There must be a class in the signature of the websocket endpoint which
is available to both webapps and the client must send and receive an echo
message to ensure that the onOpen MethodHandle is actually invoked.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue May 4, 2020
@lachlan-roberts
Merge pull request #4810 from eclipse/jetty-10.0.x-LinkageErrorInvest…
07551ba 
…igation

Issue #4800 - fix WebSocket LinkageError and invalid PathParam type handling
@lachlan-roberts
Copy link
Contributor Author

The failing test has been disabled on JDK 14, now waiting on https://bugs.openjdk.java.net/browse/JDK-8244090 to get a workaround or fix for this issue.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jun 2, 2021
@joakime
Copy link
Contributor

joakime commented Jun 2, 2021

@lachlan-roberts looks like bug https://bugs.openjdk.java.net/browse/JDK-8244090 was fixed in JDK16, do we still need this issue open?

@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Jun 2, 2021
@lachlan-roberts
Copy link
Contributor Author

Yep fixed in JDK16 so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4800 - fix WebSocket LinkageError and invalid PathParam type handling jetty/jetty.project
3 participants
@joakime @sbordet @lachlan-roberts