Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review LeakDetector & LeakTrackingConnectionPool #4949

Closed
sbordet opened this issue Jun 8, 2020 · 5 comments
Closed

Review LeakDetector & LeakTrackingConnectionPool #4949

sbordet opened this issue Jun 8, 2020 · 5 comments
Assignees
@lorban
Labels
Stale For auto-closed stale issues and pull requests

Comments

@sbordet
Copy link
Contributor

sbordet commented Jun 8, 2020

Jetty version
9.4.x

Description
Review LeakDetector to see if it's modern enough.

Also, try to make LeakTrackingConnectionPool use delegation rather than inheritance, following the model of LeakTrackingByteBufferPool.

See also #2814 for a description of the problems that LeakTrackingConnectionPool has due to the fact that uses delegation.

Benchmark the cost of the leak detector to see how expensive it is, to suggest whether it's fine to use it in "production" code or not.
@sbordet sbordet assigned sbordet and lorban and unassigned sbordet Jun 8, 2020
@sbordet sbordet mentioned this issue Jan 5, 2021
Closed
@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jun 9, 2021
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jun 10, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jun 11, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jun 13, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jun 14, 2023
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jun 14, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jun 14, 2024
@sbordet
Copy link
Contributor Author

sbordet commented Jun 14, 2024

Removed in 561fd31.

@sbordet sbordet closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Stale For auto-closed stale issues and pull requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbordet @lorban