Deprecate AbstractConnectionPool "callback" methods #5857
Assignees
Comments
|
This issue has been automatically marked as stale because it has been a |
|
This issue has been automatically marked as stale because it has been a |
|
This issue has been automatically marked as stale because it has been a |
sbordet
added a commit
that referenced
this issue
Mar 21, 2024
Deprecated idle(), acquired(), released() for removal. Renamed removed(), now deprecated, to onRemoved() to match with onCreated(). Kept onCreated() and onRemoved() as they are the only methods that are not racy. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added a commit
that referenced
this issue
Mar 22, 2024
…11542) Deprecated idle(), acquired(), released() for removal. Renamed removed(), now deprecated, to onRemoved() to match with onCreated(). Kept onCreated() and onRemoved() as they are the only methods that are not racy. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Jetty 12.0.8 - FROZEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version
9.4.x
Description
AbstractConnectionPoolhas the following "callback" methods:onCreated(Connection)idle(Connection, boolean)acquired(Connection)released(Connection)removed(Connection)They were introduced as "callbacks" for subclasses to override, but since they are called "after the fact", the
Connectionstatus maybe already changed.For example, when
idle(Connection, boolean) is called, theConnection` may already be used by some other thread N times or already be closed.Furthermore, ordering is not guaranteed so, it is possible for example that
released(Connection)is called beforeacquired(Connection).Primary user of these "callbacks" is
LeakTrackingConnectionPool, but due to the problems above it's not that reliable.This has also been reported in #2814 and also in #4949.
The text was updated successfully, but these errors were encountered: