Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty WebSocket UpgradeRequest & UpgradeResponse types in Jetty 10 #5044

Closed
lachlan-roberts opened this issue Jul 14, 2020 · 0 comments · Fixed by #5101
Closed

Jetty WebSocket UpgradeRequest & UpgradeResponse types in Jetty 10 #5044

lachlan-roberts opened this issue Jul 14, 2020 · 0 comments · Fixed by #5101
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
The UpgradeRequest and UpgradeResponse types in jetty 10 seem like they could use some simplification.

There is the API UpgradeRequest and UpgradeResponse. The Server API JettyServerUpgradeRequest and JettyServerUpgradeResponse which do not extend the API interfaces. Then there are heaps of Adapters and Delegate classes for these to convert between different interfaces. And some of the methods on these remain unimplemented.
lachlan-roberts added a commit that referenced this issue Jul 30, 2020
@lachlan-roberts
Issue #5044 - implement is secure on DelegatedJettyClientUpgradeRequest
5ff0ce4 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Jul 30, 2020
@lachlan-roberts
Issue #5044 - move all setter methods on the UpgradeRequest interface…
414a0f3 
… to ClientUpgradeRequest

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Jul 30, 2020
@lachlan-roberts
Issue #5044 - rename the ClientUpgradeRequest to CoreClientUpgradeReq…
9027e17 
…uest

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Jul 30, 2020
@lachlan-roberts
Issue #5044 - Jetty Server upgrade request/response now implement the…
3074aa7 
… API interfaces

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Jul 30, 2020
@lachlan-roberts
Issue #5044 - extend Jetty WS API Request/Response interfaces for jet…
ce8cb06 
…ty-websocket-server

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Jul 30, 2020
Merged
@joakime joakime linked a pull request Jul 30, 2020 that will close this issue
Issue #5044 - Refactor of Jetty WebSocket Upgrade Request/Response #5101
Merged
lachlan-roberts added a commit that referenced this issue Aug 5, 2020
@lachlan-roberts
Merge pull request #5101 from eclipse/jetty-10.0.x-5044-WebSocketUpgr…
1e7ce3a 
…adeRequestResponse

Issue #5044 - Refactor of Jetty WebSocket Upgrade Request/Response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5044 - Refactor of Jetty WebSocket Upgrade Request/Response jetty/jetty.project
1 participant
@lachlan-roberts