Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Scanner locking #5086

Closed
sbordet opened this issue Jul 28, 2020 · 0 comments · Fixed by #5744
Closed

Review Scanner locking #5086

sbordet opened this issue Jul 28, 2020 · 0 comments · Fixed by #5744
Assignees

Comments

@sbordet
Copy link
Contributor

sbordet commented Jul 28, 2020

Jetty version
9.4.x

Description
Scanner needs a review regarding synchronization/locking.
Many methods have the synchronized modifier, and other methods that access the same fields don't synchronize.
Also, listeners are sometimes called with the lock held, etc.

This issue should be resolved after #5083.

@sbordet sbordet changed the title Review Scanner synchronization Review Scanner locking Jul 28, 2020
@janbartel janbartel self-assigned this Nov 30, 2020
janbartel added a commit that referenced this issue Dec 1, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 1, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 1, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 1, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 1, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 2, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Dec 2, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
sbordet added a commit that referenced this issue Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants