Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad/Unsupported HTTP version should return 505 not 400 #5233

Closed
joakime opened this issue Sep 4, 2020 · 1 comment · Fixed by #5234
Closed

Bad/Unsupported HTTP version should return 505 not 400 #5233

joakime opened this issue Sep 4, 2020 · 1 comment · Fixed by #5234
Assignees
@joakime
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Sep 4, 2020

Jetty version
9.4.31

Description
There are 3 cases in HttpParser for dealing with errors around HTTP version.

  • The compliance mode. (eg: no version specified in protocol, such as HTTP/0.9)
  • A HTTP version that isn't recognized. (eg: HTTP/1.2)
  • A HTTP version that is recognized but unsupported (eg: HTTP/0.9)

We currently return an response 400 Bad Version in these cases.
The correct status code should be 505 HTTP version not supported.
@joakime joakime added the Bug For general bugs on Jetty side label Sep 4, 2020
@joakime joakime self-assigned this Sep 4, 2020
joakime added a commit that referenced this issue Sep 4, 2020
@joakime
Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400.
b2e0f69 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Sep 4, 2020 that will close this issue
Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400. #5234
Merged
joakime added a commit that referenced this issue Sep 8, 2020
@joakime
Issue #5233 - correcting NCSARequestLogTest expectation on unsupporte…
56b1d17 
…d version

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Sep 9, 2020
@joakime
Merge pull request #5234 from eclipse/jetty-9.4.x-http-09-response-505
e7d15af 
Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400.
@joakime
Copy link
Contributor Author

joakime commented Sep 9, 2020

Merged PR #5234

@joakime joakime closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400. jetty/jetty.project
1 participant
@joakime