Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyFileLoginModule retains PropertyUserStores #5486

Closed
janbartel opened this issue Oct 21, 2020 · 2 comments
Closed

PropertyFileLoginModule retains PropertyUserStores #5486

janbartel opened this issue Oct 21, 2020 · 2 comments
Assignees
@janbartel

Comments

@janbartel
Copy link
Contributor

*9.4 and above

In older versions of Jetty, we set a "refreshInterval" property on the PropertyFileLoginModule to force it to do regular hot reloads of the configured property file cached via the PropertyUserStore class. When the PropertyUserStore changed to using PathWatcher, and the setter became hotReload=true/false rather than an interval, the PropertyFileLoginModule was not modified.
@janbartel janbartel self-assigned this Oct 21, 2020
janbartel added a commit that referenced this issue Oct 27, 2020
@janbartel
Issue #5486 PropertyFileLoginModule retains PropertyUserStores
dda991c 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel
Copy link
Contributor Author

In investigating this, I've realized the problem is worse than initially thought: the PropertyFileLoginModule keeps PropertyUserStores in a static map and never stops or removes them. I'm changing the title of the issue to reflect this.

@janbartel janbartel changed the title PropertyFileLoginModule does not obey the refreshInterval PropertyFileLoginModule retains PropertyUserStores Oct 27, 2020
@janbartel janbartel mentioned this issue Oct 27, 2020
Merged
janbartel added a commit that referenced this issue Nov 2, 2020
@janbartel
Issue #5486 Changes post review
2ad27fd 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Nov 11, 2020
@janbartel
Issue #5486 PropertyFileLoginModule retains PropertyUserStores (#5518)
3a99c89 
* Issue #5486 PropertyFileLoginModule retains PropertyUserStores

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel
Copy link
Contributor Author

Merged.

@reta reta mentioned this issue Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janbartel