Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SslEngineBehaviorTest.checkSslEngineBehaviour Failure #5511

Closed
joakime opened this issue Oct 26, 2020 · 2 comments · Fixed by #5515
Closed

SslEngineBehaviorTest.checkSslEngineBehaviour Failure #5511

joakime opened this issue Oct 26, 2020 · 2 comments · Fixed by #5515
Labels
Test

Comments

@joakime
Copy link
Contributor

joakime commented Oct 26, 2020

Jetty version
9.4.x

Description
During a build/test on an overloaded machine, the SslEngineBehaviorTest.checkSslEngineBehaviour failed.

Stacktrace
org.opentest4j.AssertionFailedError: expected: <BUFFER_OVERFLOW> but was: <OK>
	at org.eclipse.jetty.io.SslEngineBehaviorTest.checkSslEngineBehaviour(SslEngineBehaviorTest.java:117)
Standard Error
2020-10-26 08:03:21.336:INFO::main: Logging initialized @2435ms to org.eclipse.jetty.util.log.StdErrLog
2020-10-26 08:03:21.476:INFO:oejus.SslContextFactory:main: x509=X509@1c3259fa(mykey,h=[],w=[]) for Server@25f15f50[provider=null,keyStore=file:///home/jenkins/agent/workspace/jetty.project_PR-5509/jetty-io/src/test/resources/keystore,trustStore=null]
Running org.eclipse.jetty.io.SslEngineBehaviorTest.checkSslEngineBehaviour()
@joakime joakime added the Test label Oct 26, 2020
@joakime
Copy link
Contributor Author

joakime commented Oct 26, 2020

@sbordet I think we should just delete this SslEngineBehaviorTest.

The way it's written, it's not reliable.
And it only runs on JDK 8.

It's an old test, from an old test class SocketChannelEndPointTest that's been refactored a few times.

See commit 423d160

joakime added a commit that referenced this issue Oct 26, 2020
@joakime
Closes #5511 - Deleting old SslEngineBehaviorTest
64d323f 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Oct 26, 2020 that will close this issue
Closes #5511 - Deleting old SslEngineBehaviorTest #5515
Merged
joakime added a commit that referenced this issue Oct 26, 2020
@joakime
Merge pull request #5515 from eclipse/jetty-9.4.x-5511-delete-SslEngi…
9617db3 
…neBehaviorTest

Closes #5511 - Deleting old SslEngineBehaviorTest
@joakime
Copy link
Contributor Author

joakime commented Oct 26, 2020

Deleted bad testcase in PR #5515

@joakime joakime closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #5511 - Deleting old SslEngineBehaviorTest jetty/jetty.project
1 participant
@joakime