Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The WebSocket ServerUpgradeResponse can produce NPE in jetty 10. #5706

Closed
lachlan-roberts opened this issue Nov 23, 2020 · 0 comments
Closed

The WebSocket ServerUpgradeResponse can produce NPE in jetty 10. #5706

lachlan-roberts opened this issue Nov 23, 2020 · 0 comments
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
The ServerUpgradeResponse class needs to be reviewed and cleaned up and tested more thoroughly. If certain websocket headers are set directly in the response we throw NPE.
@lachlan-roberts lachlan-roberts self-assigned this Nov 23, 2020
lachlan-roberts added a commit that referenced this issue Dec 8, 2020
@lachlan-roberts
Issue #5706 - fix potential NPE from websocket-core ServerUpgradeResp…
77545fa 
…onse

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Dec 8, 2020
@lachlan-roberts
Issue #5706 - fix potential NPE from websocket-core ServerUpgradeResp…
c9409be 
…onse

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Dec 21, 2020
@lachlan-roberts
Merge pull request #5768 from eclipse/jetty-10.0.x-5706-ServerUpgrade…
cf0b65e 
…Response

Issue #5706 - fix potential NPE from websocket-core ServerUpgradeResponse
@lachlan-roberts lachlan-roberts mentioned this issue Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts