Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMX-ify Scheduler implementations #5816

Closed
sbordet opened this issue Dec 16, 2020 · 3 comments · Fixed by #5821
Closed

JMX-ify Scheduler implementations #5816

sbordet opened this issue Dec 16, 2020 · 3 comments · Fixed by #5821

Comments

@sbordet
Copy link
Contributor

sbordet commented Dec 16, 2020

Jetty version
9.4.x

Description
Scheduler implementations lack JMX annotations.
Would be useful to know the scheduler name, the number of scheduler threads, whether it is daemon, etc.

@rk1165
Copy link
Contributor

rk1165 commented Dec 17, 2020

Hi @sbordet ,
How can I work on this, can you please guide me?
I have already cloned the project, signed the contributor agreement and subscribed to the mailing list. Is there anything else I need to do?

Also, please let me know if there's any prerequisite I need to read up or anything.

@sbordet
Copy link
Contributor Author

sbordet commented Dec 17, 2020

@rk1165 thanks for volunteering!

Please read the contributor guidelines: https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/CONTRIBUTING.md

In particular you have to make sure your commits are signed-off (the other requirement was the ECA, but you already signed it).

Then please have a look at how QueuedThreadPool is annotated with Jetty JMX annotations, and do something similar for ScheduledExecutorScheduler.

Please work against the jetty-9.4.x branch, make your changes, and then issue a pull request, electing me as a reviewer.

Let me know here if you need more help. Thanks!

@rk1165
Copy link
Contributor

rk1165 commented Dec 17, 2020

Hi, @sbordet
I made the aforementioned changes and raised the following PR #5821
Can you please review?

sbordet added a commit that referenced this issue Dec 18, 2020
Fixes #5816 : JMX-ify Scheduler implementations
@sbordet sbordet linked a pull request Dec 18, 2020 that will close this issue
@sbordet sbordet closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants