Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JMX support for Jetty logging #5872

Closed
sbordet opened this issue Jan 11, 2021 · 2 comments
Closed

Improve JMX support for Jetty logging #5872

sbordet opened this issue Jan 11, 2021 · 2 comments

Comments

@sbordet
Copy link
Contributor

sbordet commented Jan 11, 2021

Jetty version
10.0.x

Description
Since the Jetty Logging is initialized before anything else, it cannot rely on Jetty JMX annotations.

However, it would be great if JMX support is improved (for example by specifying parameter names to operations like JettyLoggerFactoryMBean.setLoggerLevel(String, String).

JMX has a basic support for annotations via java.management.DescriptorKey, which IIUC looks for a key in a resource bundle properties file -- may not be that bad for this once-only need.
joakime added a commit that referenced this issue Jan 12, 2021
@joakime
Issue #5872 - JMX DynamicMBean for jetty-slf4j-impl
cc8e2ab 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Jan 19, 2021
@joakime
Issue #5872 - JMX DynamicMBean for jetty-slf4j-impl
37e7361 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Jan 22, 2021
@joakime
Issue #5872 - DynamicMBean for JettyLoggerFactory
5f9ea78 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Jan 22, 2021
@joakime
Issue #5872 - DynamicMBean for JettyLoggerFactory
81c2c23 
+ Fixing typo in operation names

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Feb 2, 2021
@joakime
Merge pull request #5876 from eclipse/jetty-10.0.x-logging-jmx-dynamic
b16313b 
Issue #5872 - JMX DynamicMBean for jetty-slf4j-impl
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jan 12, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jan 12, 2022
@joakime
Copy link
Contributor

joakime commented Jan 13, 2022

We merged this into Jetty 10.x as part of PR #5876
I think this is done.

@joakime joakime closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joakime @sbordet