-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session cookie can be set twice after session id changed #7801
Labels
Bug
For general bugs on Jetty side
Comments
janbartel
added a commit
that referenced
this issue
Mar 29, 2022
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
added a commit
that referenced
this issue
Mar 30, 2022
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
added a commit
that referenced
this issue
Mar 30, 2022
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
added a commit
that referenced
this issue
Mar 30, 2022
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
added a commit
that referenced
this issue
Jun 8, 2022
* Issue #7801 Duplicate session cookies after session id change. Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel
added a commit
that referenced
this issue
Jun 8, 2022
* Issue #7801 Duplicate set session cookie after id change. Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jetty 9,10,11
When Request.changeSessionId() is called, the
isIdChanged
flag on theSession
is used to indicate that a newSet-Cookie
should be generated with the new session id. However, this flag is not cleared after the cookie is successfully generated. Thus, on the next request, theSet-Cookie
header will be generated again. The flag is then cleared correctly. Note that bothSet-Cookie
headers will be for the same session id - in other words, another session id change is not triggered, just a repetition of the same cookie session id. This only happens when using theDefaultSessionCache
, as the same session object is not retained by theNullSessionCache
.The text was updated successfully, but these errors were encountered: