Jetty-12 Improve CustomRequestLog efficiency #8819
Assignees
Labels
Comments
gregw
added a commit
that referenced
this issue
Jun 9, 2023
Resolves #8819 CustomRequestLog improvements: + only add extra detail if the log is a CustomRequestLog + add extra detail as a record + get authentication state directly from request attribute
gregw
added a commit
that referenced
this issue
Jun 13, 2023
* Resolve #8819 CustomRequestLog improvement Resolves #8819 CustomRequestLog improvements: + only add extra detail if the log is a CustomRequestLog + add extra detail as a record + get authentication state directly from request attribute * protect against null core request * protect against null core request * Use nanotime for logged latency
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Jetty 12.0.0.beta2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
Jetty-12
Enhancement Description
The current handling for servlet attributes to be logged is in
ServletChannel:https://github.com/eclipse/jetty.project/blob/jetty-12.0.0.alpha2/jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannel.java#L793-L804
This is creating 3 map keys even if they are not used. Either, they entries should only be created if used; OR create a single key with a Record containing all the attributes that might be logged (or maybe an interface with methods that can fetch the info to be logged, holding a reference to the servlet wrapper).
The text was updated successfully, but these errors were encountered: