Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12: review locking in MultiPartFormData and MultiPartByteRanges #9410

Closed
lorban opened this issue Feb 23, 2023 · 0 comments · Fixed by #9460
Closed

Jetty 12: review locking in MultiPartFormData and MultiPartByteRanges #9410

lorban opened this issue Feb 23, 2023 · 0 comments · Fixed by #9460
Assignees
@lorban
Labels
Bug For general bugs on Jetty side

Comments

@lorban
Copy link
Contributor

lorban commented Feb 23, 2023

Jetty version(s)
12

Description
Both classes call Multipart.AbstractPartsListener.fail(Throwable cause) when CompletableFuture.completeExceptionally() is called. This can happen at any time by any thread, so this code has to be thread-safe and currently isn't.
@lorban lorban added Bug For general bugs on Jetty side Jetty 12 labels Feb 23, 2023
lorban added a commit that referenced this issue Mar 1, 2023
@lorban
#9410 Improved toString() and javadoc
4f912c7 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 1, 2023
@lorban
#9410 Fix thread-safety of fail() implementations and buffer leaks
e08a914 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban mentioned this issue Mar 1, 2023
Merged
@lorban lorban linked a pull request Mar 1, 2023 that will close this issue
Fix multipart locking and buffer leaks #9460
Merged
lorban added a commit that referenced this issue Mar 1, 2023
@lorban
#9410 Fix thread-safety of fail() implementations and buffer leaks
38af054 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 1, 2023
@lorban
#9410 Fix thread-safety of fail() implementations and buffer leaks
5cae9fb 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 1, 2023
@lorban
#9410 Fix thread-safety of fail() implementations and buffer leaks
43a2e63 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 8, 2023
@lorban
#9410 handle review comments
6e27d3b 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 9, 2023
@lorban
#9410 handle review comments
7d40406 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.0.beta1 Mar 28, 2023
lorban added a commit that referenced this issue Apr 6, 2023
@lorban
#9410 handle review comments
c2b9981 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 6, 2023
@lorban
#9410 Improved toString() and javadoc
a4430ca 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 6, 2023
@lorban
#9410 Fix thread-safety of fail() implementations and buffer leaks
3505aeb 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 6, 2023
@lorban
#9410 handle review comments
9d3c330 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 6, 2023
@lorban
#9410 handle review comments
675e2fc 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 6, 2023
@lorban
#9410 handle review comments
5192dd8 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 13, 2023
@lorban
#9410 handle review comments
d1ed5ce 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 13, 2023
@lorban
#9410 Improved toString() and javadoc
c2da562 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 13, 2023
@lorban
#9410 Fix thread-safety of fail() implementations and buffer leaks
693fbcd 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 13, 2023
@lorban
#9410 Improved toString() and javadoc
45db74e 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Apr 13, 2023
@lorban
#9410 Fix thread-safety of fail() implementations and buffer leaks
f28784f 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban self-assigned this Apr 13, 2023
@lorban lorban closed this as completed Apr 13, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.0.beta1 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix multipart locking and buffer leaks jetty/jetty.project
1 participant
@lorban