Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12: WebSocket hangs when ServerEndpointConfig.Configurator.getEndpointInstance() throws #9412

Closed
sbordet opened this issue Feb 23, 2023 · 2 comments · Fixed by #9461
Closed

Jetty 12: WebSocket hangs when ServerEndpointConfig.Configurator.getEndpointInstance() throws #9412

sbordet opened this issue Feb 23, 2023 · 2 comments · Fixed by #9461
Assignees
@lorban
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Feb 23, 2023

Jetty version(s)
12

Description
Must verify that a proper upgrade request is replied timely (i.e. no blocking or such) when ServerEndpointConfig.Configurator.getEndpointInstance() throws InstantiationException.

Currently, the exception is caught by JakartaWebSocketCreator and null is returned, which eventually blocks into WebSocketUpgradeFilter because the callback is not completed.
@sbordet sbordet added the Bug For general bugs on Jetty side label Feb 23, 2023
lorban added a commit that referenced this issue Mar 2, 2023
@lorban
#9412 Fixed missing callback failure when ws endpoint cannot be insta…
0fa3ae5 
…ntiated

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban mentioned this issue Mar 2, 2023
Merged
@lorban lorban linked a pull request Mar 2, 2023 that will close this issue
Failure to instantiate a websocket endpoint is now properly reported #9461
Merged
@lorban lorban added the Jetty 12 label Mar 2, 2023
@lorban lorban moved this to 👀 In review in Jetty 12.0.0.beta1 Mar 2, 2023
@lorban
Copy link
Contributor

lorban commented Mar 2, 2023

JakartaWebSocketCreator is correctly catching InstantiationException, and is supposed to return null when this happens, that part is fine.

But the catch block is missing a call to callback.failed(e).

lorban added a commit that referenced this issue Mar 2, 2023
@lorban
#9412 ee10: Fixed missing callback failure when ws endpoint cannot b…
b0a2c21 
…e instantiated

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 2, 2023
@lorban
#9412 ee9: Fixed missing callback failure when ws endpoint cannot be…
52d4d73 
… instantiated

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban
Copy link
Contributor

lorban commented Mar 2, 2023

Both EE9 and EE10 suffer from this bug.

lorban added a commit that referenced this issue Mar 6, 2023
@lorban
#9412 ee10: Fixed missing callback failure when ws endpoint cannot b…
5bac801 
…e instantiated

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 6, 2023
@lorban
#9412 ee9: Fixed missing callback failure when ws endpoint cannot be…
62382de 
… instantiated

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 8, 2023
@lorban
#9412 ee10: Fixed missing callback failure when ws endpoint cannot b…
e266db1 
…e instantiated

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Mar 8, 2023
@lorban
#9412 ee9: Fixed missing callback failure when ws endpoint cannot be…
71c2ef2 
… instantiated

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban self-assigned this Mar 8, 2023
@lorban lorban closed this as completed Mar 8, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Jetty 12.0.0.beta1 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Failure to instantiate a websocket endpoint is now properly reported jetty/jetty.project
2 participants
@sbordet @lorban