Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12: HttpCookieStore should return cookies for "ws" schemes #9440

Closed
sbordet opened this issue Feb 26, 2023 · 1 comment · Fixed by #9441
Closed

Jetty 12: HttpCookieStore should return cookies for "ws" schemes #9440

sbordet opened this issue Feb 26, 2023 · 1 comment · Fixed by #9441
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Feb 26, 2023

Jetty version(s)
12+

Description
HttpClient is used for sending the WebSocket upgrade request.
For such cases, the request URI has typically the ws or wss scheme.

The current implementation of HttpCookieStore.Default uses the scheme as part of the key used to store cookies, but that is not really necessary, as the scheme is subsequently never used.
The only information that must be retained from the scheme is whether it is a secure scheme or not, which would allow other schemes such as ws to work seamlessly, rather than having to perform expensive URI/string mangling to replace ws schemes to http when accessing the HttpCookieStore.
@sbordet sbordet added the Bug For general bugs on Jetty side label Feb 26, 2023
sbordet added a commit that referenced this issue Feb 26, 2023
@sbordet
Fixes #9440 - Jetty 12: HttpCookieStore should return cookies for "ws…
41c1ef7 
…" schemes

Now only using whether the scheme is secure in the key used to store cookies,
not the scheme string.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Feb 26, 2023 that will close this issue
Fixes #9440 - Jetty 12: HttpCookieStore should return cookies for "ws… #9441
Merged
sbordet added a commit that referenced this issue Feb 26, 2023
@sbordet
Fixes #9440 - Jetty 12: HttpCookieStore should return cookies for "ws…
e4c46b1 
…" schemes (#9441)

Now only using whether the scheme is secure in the key used to store cookies,
not the scheme string.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
Copy link
Contributor Author

sbordet commented Feb 26, 2023

Fixed by #9441.

@sbordet sbordet closed this as completed Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #9440 - Jetty 12: HttpCookieStore should return cookies for "ws… jetty/jetty.project
1 participant
@sbordet