Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetty-12 ee10 PushBuilderImpl.push must throw IllegalStateException #9656

Closed
janbartel opened this issue Apr 17, 2023 · 1 comment
Closed
Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@janbartel
Copy link
Contributor

According to the PushBuilder.push javadoc, a PushBuilder must throw an IllegalStateException if there has been no call to path method:

     * @throws IllegalStateException if there was no call to {@link #path} on this instance either between its instantiation
     * or the last call to {@code push()} that did not throw an IllegalStateException.

Our PushBuilderImpl class is throwing IllegalArgumentException instead.

This affects the following tck test:

com/sun/ts/tests/servlet/spec/serverpush/Client.java.serverPushNegtiveTest

@janbartel janbartel added Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Apr 17, 2023
@janbartel
Copy link
Contributor Author

Closed via #9667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Development

No branches or pull requests

1 participant