Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove integer for demand in websocket in Jetty-12 #9944

Closed
lachlan-roberts opened this issue Jun 21, 2023 · 0 comments
Closed

Remove integer for demand in websocket in Jetty-12 #9944

lachlan-roberts opened this issue Jun 21, 2023 · 0 comments
Assignees
@lachlan-roberts
Labels
Enhancement

Comments

@lachlan-roberts
Copy link
Contributor

lachlan-roberts commented Jun 21, 2023 •
edited
Loading

Enhancement Description

We use the signature void demand(long n); for demand in websocket, however we only ever use or have a usecase for demand(1). So we should remove the long field and just have a demand() interface.
@gregw gregw moved this to 🏗 In progress in Jetty 12.0.0.beta3 Jun 21, 2023
@lachlan-roberts lachlan-roberts self-assigned this Jun 21, 2023
lachlan-roberts added a commit that referenced this issue Jun 21, 2023
@lachlan-roberts
Issue #9944 - remove integer from demand in websocket core
9e99a58 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts moved this from 🏗 In progress to 👀 In review in Jetty 12.0.0.beta3 Jun 22, 2023
lachlan-roberts added a commit that referenced this issue Jun 28, 2023
@lachlan-roberts
Merge pull request #9945 from eclipse/jetty-12.0.x-WebSocketDemand
0941969 
Issue #9944 - remove integer from demand in websocket core
@gregw gregw moved this from 👀 In review to ✅ Done in Jetty 12.0.0.beta3 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lachlan-roberts